Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] rust: set _bootstrapping=no for all architectures #16207

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[WIP] rust: set _bootstrapping=no for all architectures #16207

wants to merge 2 commits into from
+30 −23

Conversation

filnet
Copy link
Contributor

@filnet filnet commented Mar 14, 2023

No description provided.

@filnet
Copy link
Contributor Author

filnet commented Mar 14, 2023

It's experimental. Please don't merge.

@filnet filnet changed the title rust: set _bootstrapping=no for all architectures [WIP] rust: set _bootstrapping=no for all architectures Mar 14, 2023
@filnet
Copy link
Contributor Author

filnet commented Mar 14, 2023

The bootstrapping=no mode will tell the Rust build to use the local rust.
The rust package must therefore be added to makedepends.

We know this mode works for aarch64 and here I am testing it on other architectures.

The bootstrapping=yes mode lets the build proceed by default.
It will download and use the latest official release of rust (which does not exist for aarch64?).

The big issue with using the local rust is that it must be the latest.
This means we can't skip a beat and must produce all versions...

@filnet
Copy link
Contributor Author

filnet commented Mar 14, 2023

So it is "eat our own dog food" or "play it safe".
aarch64 being in the former category.

@lazka lazka marked this pull request as draft March 14, 2023 23:20
@filnet
Copy link
Contributor Author

filnet commented Mar 15, 2023

Are build time stable/reproducible or random ?

@filnet filnet mentioned this pull request Mar 15, 2023
Open
@filnet filnet force-pushed the update_rust branch 2 times, most recently from 51566b8 to 6022466 Compare March 23, 2023 22:12
@Biswa96
Copy link
Member

Biswa96 commented Mar 24, 2023

0013-revert-lib-host-symlink.patch file was not removed.

@filnet filnet force-pushed the update_rust branch 3 times, most recently from 8e371ba to d83d1ce Compare March 28, 2023 16:27
@filnet filnet mentioned this pull request Apr 23, 2023
Merged
@filnet
Copy link
Contributor Author

filnet commented Apr 23, 2023

Forgot to push the upgrade to 1.69.0 (was still on the pre-release).

@jeremyd2019 jeremyd2019 mentioned this pull request Jun 3, 2023
Merged
@filnet filnet force-pushed the update_rust branch 2 times, most recently from 5e6fa9c to d591422 Compare July 12, 2023 18:02
@filnet filnet force-pushed the update_rust branch 3 times, most recently from 05db071 to 8bbb90d Compare August 23, 2023 13:45
@filnet filnet force-pushed the update_rust branch 2 times, most recently from 1704ea7 to 211f955 Compare September 19, 2023 14:30
@filnet filnet force-pushed the update_rust branch 2 times, most recently from 63fc65d to f8c4359 Compare October 5, 2023 19:47
@filnet filnet force-pushed the update_rust branch 2 times, most recently from 608bc7a to 12f22aa Compare December 29, 2023 11:21
@filnet filnet force-pushed the update_rust branch 2 times, most recently from ef05223 to 22b5201 Compare February 8, 2024 20:37
@filnet filnet force-pushed the update_rust branch 2 times, most recently from ca450a3 to 4d27f22 Compare April 4, 2024 17:44
@filnet filnet force-pushed the update_rust branch 4 times, most recently from 6953943 to 356ad48 Compare May 3, 2024 19:53
filnet added 2 commits May 4, 2024 01:38
@filnet
rust: update to 1.78.0
e377811
@filnet
rust: set _bootstrapping=no for all architectures (not just aarch64)
db6ae1b 
when _bootstrapping=no, the rust build is configured to use the local rust for stage 0.
stage 0 will use the installed MSYS2 rust (must be the latest version...).

when _bootstrapping=yes, the build is configured to download and extract the previous rust version.
in this case, the official rust build will be used which kind of defeats the point (?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filnet @Biswa96