Release rc.10

[dmtrKovalenko]

We apologize for long break between releases. But we have done a lot inside ⭐️

Big thanks to 6 contributors, that makes this release possible ❤️
Here is what's changed:

Breaking changes

We have redone forwarding refs logic with the new React's api. So no more pickerRef prop

<DatePicker
- pickerRef={node => { this.picker = node }}
+ ref={node => { this.picker = node }}
/>

Features

• We have move from inheritance to composition and providing our internal hoc for using any pickers sub-component (read more here) @dmtrKovalenko
• Accept date on text field blur instead of on any successful parse. @LastDreamer
• Introduce new TimePicker view with seconds. Use seconds prop @baig
• Switched to new lifecycle components Plan to switch to new lifecycle method in React 16.3 ? #422
• Accept react components for messages and labels Make messages and labels accept components #387
• Allow to disable keyboard event listener by setting allowKeyboardControl to false.

Fixes

• Make calendar keyboard event listener disabled by default if its used not under modal Unusual issue: EventListener on window in Calendar component caused unexpected behavior #412
• Fix that autoOk prop break keyboard input autoOk breaks keyboard input #432
• Fix not applying disabled effect for keyboard button if textfield disabled DatePicker KeyboardIcon button is enabled even if disabled is set to true #452
• [ts] Fix missing onKeyDown typescript property for DateTextFieldProps @ahmad Ilaiwi
• [ts] Fix missing todayLabel and showTodayButton for pickers props @tjaskula

[dmtrKovalenko]

@cherniavskii will you have any chance to briefly review it? Thank you

[cherniavskii]

looks like it's also breaking change - it was enabled by default

[dmtrKovalenko]

Actually its not a breaking change - because its enabled in the DatePickerWrapper.
The logic is - if you are using default wrapper with modal you have events disabled. If you are using some internal component - you got its disabled

[cherniavskii]

I've got confused with DatePicker and DatePickerWrapper components once again :/
Okay, it's not a breaking change.

[dmtrKovalenko]

:D I think we should rename them in the next iteration

[cherniavskii]

hmm, okLabel is used as aria-label in Button component. Same with other labels. Wouldn't that break aria-labels?

[baig]

I've added support for seconds in DateTimePicker as well. I will open another pull request for that.

[mcMickJuice]

@dmtrKovalenko I'm noticing a couple bugs with develop, both affecting DatePicker:

Cannot select other dates

When the calendar is open, today's date (or whatever value is) is selected, but you cannot select other dates.

I updated #459 with fixes for these changes since these issues are all tightly related.

autoOk flag is not respected

If autoOk is true, selecting a date does not close the modal. This is because we're not getting a ref to ModalWrapper to call close on it.

Separate Issue related to date initialization

I think we need to have a separate method in BasePicker for initializing the date of a picker when it's opened. Calling handleChange from componentDidMount in Calendar is specific enough. OR we augment getValidDateOrCurrent in BasePicker to handle setting initial date value.

I prefer the latter since for #450 will also likely require messing with getValidDateOrCurrent for setting the default date if no value is passed:

const getValidDateOrCurrent = ({ utils, value, initialFocusedDate }) => {
+  const initialDate = value || initialFocusedDate || utils.date();

-  const date = utils.date(value);
+  const date = utils.date(initialDate);

- return utils.isValid(date) && value !== null ? date : utils.date();
+  return utils.isValid(date) ? date : utils.date();
};

[dmtrKovalenko]

@mcMickJuice thank you, your PR fixes all of these issues?

[mcMickJuice]

Nope, sorry here are the DatePicker related issues and checked are what my PR fixes:

• Cannot select other dates while picker is open
• Picker is auto assigning minDate if value is null and minDate > today (DatePicker autosets value to minDate if value is null, autoOk is true and minDate is greater than current date #445)
• autoOk prop is not being respected

Based on looking at the code in BasePicker and cursory testing, the autoOk issue is affecting all components (DatePicker, DateTimePicker, TimePicker).

[dmtrKovalenko]

I think we are ready to release 🚀

[mcMickJuice]

So you're handling opening/closing of Modal declaratively, using isAccepted as the signal to close, correct? As opposed to imperatively using a ref to ModalWrapper?

[dmtrKovalenko]

@mcMickJuice you are exactly right

[mcMickJuice]

cool! thanks