-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] Add example using nextjs & @mui/styles as a starter for the migration to v5 #33005
[examples] Add example using nextjs & @mui/styles as a starter for the migration to v5 #33005
Conversation
…r migration to v5
cc @siriwatknp could you review from technical point of view? Should we also link it here - https://mui.com/material-ui/getting-started/example-projects/#main-content ? |
Good question. Both the "getting started" and the "migrating from JSS" pages contain this text:
I think it would make sense to add a line or two in this section on both pages to say that you can check out this example project to see how to upgrade to v5 while continuing to use
Definitely! I think it would also be worthwhile to write a blog post to explain the setup and hopefully catch more frustrated devs looking for a solution on Google. 😁 I'm happy to take that on. |
"@emotion/cache": "^11.7.1", | ||
"@emotion/react": "^11.9.0", | ||
"@emotion/server": "^11.4.0", | ||
"@emotion/styled": "^11.8.1", | ||
"@mui/icons-material": "^5.0.0", | ||
"@mui/material": "^5.0.0", | ||
"@mui/styles": "^5.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should mark them as latest
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samuelsycamore I wonder if we need to mention in the migration guide that React 18 upgrade should be done after MUI upgrade?
Currently, we only mention about the minimum version of React
cc @mnajdova does it make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
React 18 upgrade should be done after MUI upgrade
If you mean: React 18 upgrade should be done after @mui/styles
is replaced with one of the alternatives, than yes, good point 👍
Co-authored-by: Siriwat K <siriwatkunaporn@gmail.com>
…ub.com/mnajdova/material-ui into docs/add-nextjs-with-mui-styles-and-v5
cc @siriwatknp & @samuelsycamore would be great to push this and #33063 (comment) for next week release :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent addition!
docs/data/material/migration/migration-v4/migrating-from-jss.md
Outdated
Show resolved
Hide resolved
examples/nextjs-with-typescript-v4-migration/pages/_document.tsx
Outdated
Show resolved
Hide resolved
examples/nextjs-with-typescript-v4-migration/pages/_document.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Closes #29428
The PR adds new example project that can serve as a starting point when migrating to v5. The #29428 revealed that lot of people are struggling with this, so adding the example should hopefully help.
The PR should be merged after #32740, so that we can link it where appropriate.