Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blog] Add post about v5 Migration guide update #33063

Merged
merged 17 commits into from
Jun 20, 2022
Merged

[blog] Add post about v5 Migration guide update #33063

merged 17 commits into from
Jun 20, 2022

Conversation

samuelsycamore
Copy link
Contributor

@samuelsycamore samuelsycamore commented Jun 7, 2022

Preview: https://deploy-preview-33063--material-ui.netlify.app/blog/migration-update/

This PR adds a post to the blog to inform users that we've updated the Migration guide.

Since this wasn't substantial enough to flesh out into a whole article, I've framed it in terms of "top reasons why you should migrate to v5" as a way to provide the reader with more value and ideally strengthen the call to action (to check out the new migration guide).

@mui-bot
Copy link

mui-bot commented Jun 7, 2022

No bundle size changes

Generated by 🚫 dangerJS against 53fec57

@mnajdova
Copy link
Member

mnajdova commented Jun 8, 2022

@samuelsycamore would be great if we can also merge #33005 before the blogpost :)

@mnajdova
Copy link
Member

mnajdova commented Jun 8, 2022

Also on the tweet we could mention:

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, left one suggestion, feel free to disregard if you don't think it's worth mentioning :)

docs/pages/blog/migration-update.md Show resolved Hide resolved
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content-wise it's great! Short and simple!

My only consideration is: I wonder if we shouldn't add a couple of examples for the new styling engine (what's the difference from a code perspective); global class names (how does that look like); and IntelliSense (maybe a gif of VS Code with it working?).

Additionally, I added the OG image card but I'm not sure if it'll work given the image is not used within the .md file... @siriwatknp would you know about that?

@siriwatknp
Copy link
Member

Additionally, I added the OG image card but I'm not sure if it'll work given the image is not used within the .md file... @siriwatknp would you know about that?

@danilo-leal The path looks good except for the image extension. It should be .png

@samuelsycamore
Copy link
Contributor Author

My only consideration is: I wonder if we shouldn't add a couple of examples for the new styling engine (what's the difference from a code perspective); global class names (how does that look like); and IntelliSense (maybe a gif of VS Code with it working?).

All great ideas, thanks @danilo-leal! I always struggle to come up with ways to add visual appeal to articles like this! I'll incorporate these suggestions into the next draft.

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking awesome, excellent work!

Added an additional image there just so the post is a bit more eye-catching and also edited a bit the IntelliSense one 👌

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Updated the thumbnail to .png to show on social preview.

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

I have seen some people looking for moving to v5 because of the new components/features in MUI X. I wonder if it's something that can resonate.

Emotion unlocks many new customization options that developers had been requesting for years, such as custom style utility props, color variants, and custom theme variants.
Check out [this RFC on GitHub](https://github.com/mui/material-ui/issues/22342) for details about this change.

![Screenshot of the new style engine GitHub issue in Material UI's repository](/static/blog/migration-update/style-engine.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried to click on this image 😁

docs/pages/blog/migration-update.md Show resolved Hide resolved
docs/pages/blog/migration-update.md Outdated Show resolved Hide resolved
docs/pages/blog/migration-update.md Outdated Show resolved Hide resolved
docs/pages/blog/migration-update.md Outdated Show resolved Hide resolved
docs/pages/blog/migration-update.md Outdated Show resolved Hide resolved
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blockers from my side :)

samuelsycamore and others added 4 commits June 16, 2022 08:31
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
samuelsycamore and others added 2 commits June 16, 2022 11:33
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants