[Popover] Fix paper position flash on open #34546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheUnlocked
changed the title
1 task
|
Thanks for your work. Your fix seems to work. I'm going to test it more thoroughly. BTW, the affected components, such as Select will be implemented using MUI Base in the future, which doesn't suffer from this issue AFAIK. This way the implementation will be simpler. |
michaldudak
added
bug 🐛
michaldudak
approved these changes
Oct 11, 2022
alexfauquette
pushed a commit
to alexfauquette/material-ui
that referenced
this pull request
Oct 14, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Changes
Previously popovers could have been rendered before they were positioned, resulting in them briefly appearing in the top-left corner particularly on slower devices and with low
transitionDuration. This PR hides the popover paper until positioning is complete.Drawbacks
On slower devices, the opening animation may be completely skipped since the animation would complete before positioning would finish. This can be demonstrated with the Chrome dev tools' CPU throttling feature. Due to the current way that popover is designed, there is a sort of catch-22 in which the the paper only mounts once the transition begins, but positioning can only occur after the paper mounts. Changing other parts of the code to get around that issue is certainly possible, but I have not attempted to do that in this PR.
Resolves #33308