Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-next][Switch] Copy Switch to material next #39887

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

lhilgert9
Copy link
Contributor

@lhilgert9 lhilgert9 commented Nov 15, 2023

Switch issue: #39886
Material You umbrella issue: #29345

Changes

  • Copy Switch from material v5
  • Fix imports

Known Issues

The Switch component currently still uses the base component from material-ui. In the next PR, this will be replaced by the useSwitch hook.

@mui-bot
Copy link

mui-bot commented Nov 15, 2023

Netlify deploy preview

https://deploy-preview-39887--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against ad75146

@lhilgert9 lhilgert9 marked this pull request as ready for review November 15, 2023 15:46
@lhilgert9 lhilgert9 requested a review from mnajdova November 16, 2023 11:53
@zannager zannager added the component: switch This is the name of the generic UI component, not the React module! label Nov 16, 2023
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mnajdova mnajdova merged commit c20d953 into mui:master Nov 16, 2023
21 checks passed
@lhilgert9 lhilgert9 deleted the copy-switch-to-material-next branch November 16, 2023 15:29
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: switch This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants