Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-next][Switch] Change files to TypeScript #39894

Merged
merged 10 commits into from
Dec 26, 2023
Merged

[material-next][Switch] Change files to TypeScript #39894

merged 10 commits into from
Dec 26, 2023

Conversation

lhilgert9
Copy link
Contributor

@lhilgert9 lhilgert9 commented Nov 16, 2023 •
edited
Loading

Switch issue: #39886
Material You umbrella issue: #29345

Changes

  • Change Switch files to TS
  • Fix ts errors
  • Apply new type style

@lhilgert9 lhilgert9 mentioned this pull request Nov 16, 2023
Open
7 tasks
@mui-bot
Copy link

mui-bot commented Nov 16, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-39894--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 3d1b302

@lhilgert9 lhilgert9 marked this pull request as ready for review November 16, 2023 16:13
@zannager zannager added the component: switch This is the name of the generic UI component, not the React module! label Nov 16, 2023
@zannager zannager requested a review from mj12albert November 16, 2023 17:35
lhilgert9 and others added 2 commits November 17, 2023 13:31
@lhilgert9 @mnajdova
Update Switch.types.ts
a8388e0 
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
Signed-off-by: Lucas Hilgert <77863078+lhilgert9@users.noreply.github.com>
@lhilgert9
fix eslint error
be63176
@lhilgert9 lhilgert9 requested a review from mnajdova November 17, 2023 13:23
@lhilgert9
Copy link
Contributor Author

@mj12albert @mnajdova Since #39935 is now merged, I have changed the types accordingly. Now everything should be ready in this PR.

@lhilgert9 lhilgert9 requested a review from mj12albert November 22, 2023 13:13
@danilo-leal danilo-leal added the package: material-ui Specific to @mui/material label Nov 23, 2023
@danilo-leal danilo-leal changed the title [material-next][Switch] Change Switch files to ts [material-next][Switch] Change files to TypeScript Nov 23, 2023
@lhilgert9
Copy link
Contributor Author

@mj12albert @mnajdova What about this PR?

@DiegoAndai DiegoAndai added v7.x and removed v6.x labels Dec 26, 2023
@DiegoAndai DiegoAndai added this to the Material UI: v7 draft milestone Dec 26, 2023
@DiegoAndai DiegoAndai self-requested a review December 26, 2023 19:31
DiegoAndai
DiegoAndai approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay @lhilgert9 😊

@DiegoAndai DiegoAndai merged commit 9f6f4b9 into mui:master Dec 26, 2023
22 checks passed
@lhilgert9 lhilgert9 deleted the change-switch-files-to-ts branch December 26, 2023 20:12
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Jan 9, 2024
@lhilgert9 @mnajdova
[material-next][Switch] Change files to TypeScript (mui#39894)
d78c459
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoAndai DiegoAndai DiegoAndai approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

@mj12albert mj12albert Awaiting requested review from mj12albert

Assignees
No one assigned
Labels
component: switch This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material v7.x
Projects
None yet
Milestone
Material UI v8 (draft)
Development

Successfully merging this pull request may close these issues.
8 participants
@lhilgert9 @mui-bot @mnajdova @mj12albert @DiegoAndai @oliviertassinari @danilo-leal @zannager