This repository has been archived by the owner on Oct 19, 2022. It is now read-only.
feat: consolidate select write #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
suggested changes
Sep 26, 2019
|
Added changes per feedback including package lock removal. I also bumped the dependencies of the newly released modules. |
jacobheun
added a commit
that referenced
this pull request
Oct 10, 2019
* chore: update deps * chore: remove package lock
jacobheun
added a commit
that referenced
this pull request
Oct 10, 2019
* chore: update deps * chore: remove package lock
jacobheun
added a commit
that referenced
this pull request
Oct 11, 2019
* refactor: use async / await (#52) BREAKING CHANGE: The API has changed from callbacks to async/await. Additionally, the use has changed. See the README for usage guidance. * feat: consolidate select write (#53) * chore: update deps * chore: remove package lock * chore: update contributors * chore: release version v0.15.0 * chore: fix contributors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consolidates the select write so that the multistream protocol and the first select protocol are sent in the same packet. This saves a round trip.
Ideally, we would also add a small delay before replying to the select response to do the same action when responding, but I am saving that for a separate PR.
I also updated some logs to make it easier to understand what's going on. Using this on the libp2p core refactor I was having a hard time understanding the order of the log messages.
I took the
to-reader-writerlogic and createdit-handshakebased off of that, as we will need support for this in other modules.