-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #10307: Rearranged Palettes #10363
Fix #10307: Rearranged Palettes #10363
Conversation
900fffe
to
505b75a
Compare
@bkunda, I could not add the icon for Staff Type Change. Also, in the issue, you had asked me to change description of a cell to "Chant Caesura". I changed it to "Chant caesura" to make it consistent with other descriptions. If you want to me to change it to the former, please tell me. |
Sentence case is correct so you're spot on about this! 🙌🏻 I'll follow up separately with our dev team re: that extra icon. There are a few other questions I have about that palette so we will resolve it at some point soon I'm sure. Many thanks again! 🙏🏻 |
@bkunda, can you please check Bagpipe Embellishments palette. Its a bit too long in my opinion |
505b75a
to
b7ed3ad
Compare
a67bfd6
to
40f3145
Compare
From a UX perspective, this is working well. Great work @HemantAntony. Meanwhile @RomanPudashkin, could you or one of your colleagues please just have a look at this code and give @HemantAntony any feedback before we finalise everything? Final adjustments (For now... 😉 ): Tempo
Fingering
Arpeggios & glissandi:
They appear too high up in the upper right corner of their respective palette tile. It would be great if they could be centred somehow. If this could be achieved, I’d like to see the palette properties for this as follows: Grace notes
Breaths and pauses
Repeats and jumps
Dynamics
Hope this makes sense. @HemantAntony let me know if you have any questions, and thank you so much for your work on this! 🙏🏻 |
40f3145
to
9613742
Compare
@HemantAntony this is almost ready from my end! Width=42 Many thanks, |
9613742
to
6b16fd3
Compare
I updated the PR. Also @RomanPudashkin, was I supposed to have created this PR with different commits instead of a single one |
@Eism @RomanPudashkin @igorkorsukov this looks good to me from a UX perspective. If one of you could please have a look at it, that would be great. I've only tested on MacOS (the scaling issue in Windows means I can't accurately see the scaling of palette objects, I can't test it yet in this environment). Many thanks @HemantAntony! |
Overall looks very good! I left several small comments for you. This PR can be merged after resolving them. Thank you! |
6b16fd3
to
fc319f3
Compare
Please don't merge yet. I'm looking at another related issue |
@@ -3805,7 +3805,7 @@ constexpr const std::array<const char*, size_t(SymId::lastSym) + 1> SymNames::s_ | |||
"Punctum auctum, ascending", | |||
"Punctum auctum, descending", | |||
"Augmentum (mora)", | |||
QT_TRANSLATE_NOOP("symUserNames", "Caesura"), | |||
QT_TRANSLATE_NOOP("symUserNames", "Chant caesura"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the name used in SMuFL!
Yes, the glyph is chantCaesura
, but the clear text name is "Caesura" (unfortunatly, complain to SMuFL).
See fonts/smufl/glyphnames.json:
"chantCaesura": {
"codepoint": "U+E8F8",
"description": "Caesura"
},
Whenever ...tools/fonttools/smufl2sym.{sh,bat} is run again, it'd revert this change.
See #6152, when this got added to 3.x and 7d70696 for master, esp. the commented out code in the mtests checking for duplicates, as in 3.x this was only in the master palette.
See #10531
see musescore#10363 and the discussion there
see musescore#10363 and the discussion there
Resolves: #10307