Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

|MU4] Revert renaming of chantCaesura's name #10531

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz commented Feb 11, 2022

This is not the name used in SMuFL!
Yes, the glyph is chantCaesura, but the clear text name is "Caesura".
See fonts/smufl/glyphnames.json:

	"chantCaesura": {
		"codepoint": "U+E8F8",
		"description": "Caesura"
	},

Whenever ...tools/fonttools/smufl2sym.{sh,bat} is run again, it'd revert this change.

See #6152, when this got added to 3.x and 7d70696 for master, esp. the commented out code in the mtests checking for duplicates, as in 3.x this was only in the master palette.

I've submitted w3c/smufl#215, maybe this will change in the futur. Until then we have this PR here ;-)

@RomanPudashkin RomanPudashkin merged commit 9f71ee9 into musescore:master Feb 11, 2022
@Jojo-Schmitz Jojo-Schmitz deleted the chantCaesura branch February 11, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants