Rework anchor lines drawing #5738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failure is related to the issue #301436 which is already present in master, so it is better to fix that issue rather than this particular crash on a test scenario. |
dmitrio95
force-pushed
the
anchors_drawing
branch
3 times, most recently
from
0b58f53
to
55a3600
Compare
dmitrio95
force-pushed
the
anchors_drawing
branch
2 times, most recently
from
30365bb
to
45488bf
Compare
dmitrio95
force-pushed
the
anchors_drawing
branch
2 times, most recently
from
c2e06ae
to
a68c899
Compare
dmitrio95
force-pushed
the
anchors_drawing
branch
from
a68c899
to
91431b7
Compare
|
I reckon the "work in progress" label should go? |
| @@ -75,10 +75,14 @@ void ScoreView::doDragElement(QMouseEvent* ev) | |||
| mscore->play(e); | |||
| _score->setPlayNote(false); | |||
| } | |||
| QLineF anchor = e->dragAnchor(); | |||
| QVector<QLineF> anchorLines = e->dragAnchorLines(); | |||
| const QPointF pageOffset(e->findAncestor(ElementType::PAGE)->pos()); | |||
There was a problem hiding this comment.
I think this might be where we are getting the extra page offset that is causing https://musescore.org/en/node/306096. If I comment out the translate that happens below, it fixes the case at hand, but I'm not totally sure it doesn't break something else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of redesign of elements dragging system which I got split off the
anchors_rebasingbranch to make the amount of changes more manageable. This PR is dedicated to anchor lines drawing redesign and includes:Possibly some more changes could be added in future.