Rebase segment-anchored lines on dragging #5763
Conversation
libmscore/articulation.h
Outdated
| @@ -98,7 +98,7 @@ class Articulation final : public Element { | |||
| virtual void write(XmlWriter& xml) const override; | |||
| virtual bool readProperties(XmlReader&) override; | |||
|
|
|||
| virtual QLineF dragAnchor() const override; | |||
| QVector<QLineF> dragAnchorLines() const override; | |||
There was a problem hiding this comment.
I notice that you've removed virtual specifiers on member-function declarations that are declared as override, both here and elsewhere.
Is this a new official coding guideline?
I like having virtual there, even though it's technically redundant.
There was a problem hiding this comment.
No it isn't defined by any coding guidelines in MuseScore right now. But maybe we should come to some single style here.
Somewhat in defense of this change, Google C++ Style Guide suggests not writing virtual in this case:
Explicitly annotate overrides of virtual functions or virtual destructors with exactly one of an override or (less frequently) final specifier. Do not use virtual when declaring an override.
dmitrio95
force-pushed
the
anchors_rebasing
branch
from
7c150a0
to
69ffcb7
Compare
dmitrio95
force-pushed
the
anchors_rebasing
branch
2 times, most recently
from
6b3175d
to
82eabca
Compare
dmitrio95
force-pushed
the
anchors_rebasing
branch
from
82eabca
to
d8050b0
Compare
|
@dmitrio95 rebase needed |
This allows to define a ratio which is used to split canvas between the adjacent segments, systems etc.
Also restore an ability to use Ctrl or Shift for horizontal/vertical drag of lines
Also draw anchor lines for multiple selected elements on dragging
Restructure lines anchors rebasing code, allow for reliable line span change between systems
dmitrio95
force-pushed
the
anchors_rebasing
branch
from
d8050b0
to
c026ade
Compare
|
Rebased |
Fixup for PR musescore#5763, especially for changes in ad6c858
This PR (currently based on the branch from #5738) contains reworking dragging system, primarily related to dragging segment-anchored lines (like hairpins). These changes make hairpin anchors be recalculated based on actual hairpin position on dragging without the need to use special key combinations like Shift+arrow for this purpose. This should make editing score dynamics (as well as aspects related to other segment-anchored lines) easier.