Restore status text and screen reader output #6210

shoogle · 2020-06-12T01:37:32Z

Resolves:

Fixes bugs and regressions from PR #6173.

I signed CLA
I made sure the code in the PR follows the coding rules
I made sure the code compiles on my machine
I made sure there are no unnecessary changes in the code
I made sure the title of the PR reflects the core meaning of the issue you are solving
I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
I made sure the commit message title starts with "fix #424242:" if there is a related issue
[N/A] I created the test (mtest, vtest, script test) to verify the changes I made

shoogle · 2020-06-12T02:29:30Z

mscore/scoreaccessibility.cpp

-      if (w->score()->accessibleMessage().isEmpty())
-            currentInfoChanged();
+      currentInfoChanged();


The accessibleMessage string is cleared in the function AccessibleScoreView::text(), but that function only gets called if there is a screen reader running. If there is no screen reader then accessibleMessage would never be emptied after it was first set, hence currentInfoChanged() was never called to set the status bar text.

MarcSabatella · 2020-06-12T03:59:42Z

I can confirm it fixed this issue on Linux; can check on Windows with NVDA and JAWS on Friday to be sure I don’t see any other effects.

shoogle · 2020-06-12T16:24:31Z

@MarcSabatella, the thing to listen for is whether your accessibleInfo string is over-optimized, because now there will be occasions when currentInfoChanged() is called but the calculated accessibleInfo string will not get used. Next time currentInfoChanged() is called the string will get optimized again, possibly removing bar and beat numbers that should have been spoken.

MarcSabatella · 2020-06-12T18:26:29Z

Understood. Most likely I won't be able to spend much time on this today. It was all kind of a delicate balance before that mostly just worked by accidental of how NVDA happened to respond, but it would be good to figure out what's going on with JAWS too. I should be able to find time for that next week.

BTW, so far making the timer thing not active on Linux seems an improvement overall, but I need to spend more time with that too.

MarcSabatella · 2020-06-15T17:09:39Z

mscore/scoreaccessibility.cpp

-                  return msg;
+                  if (info.isEmpty())
+                        return msg;
+                  return tr("%1, %2").arg(msg).arg(info);


Can you summarize when you expect this to hold? Is it to read the mode text and note info?

Exactly. Typical values are:

msg = "Steptime note input mode"; info = "Note C4 (quarter), beat 3, measure 1, staff 2";

msg could also relate to an action, such as "Staccato above added", but info always describes the current selection.

Looking through the code paths, it does seem these would always be distinct - I had worried at first they might be the same. Now the only thing I'd be concerned about is if there is ever a time when navigating through text (so msg is the character to read) that info would not have already been cleared and would still have the full text. Not that I know of a case offhand, but that's what I'll still want to test.

@MarcSabatella, you were right to be concerned, hence I have explicitly emptied the info string during text editing. See below.

anatoly-os · 2020-06-16T09:55:21Z

LGTM. @MarcSabatella do you confirm?

MarcSabatella · 2020-06-16T16:07:15Z

It does, although I haven't yet tested the lastest change to concatenate message & info. At least I don't think that was in when I did my last test. Will do so today, and do another round of checks on JAWS and Orca.

MarcSabatella · 2020-06-16T17:34:18Z

Orca definitely does read the full text on each cursor movement, but it did that for the beta too, so this PR isn't a regression in that sense. And things are smoother overall than the beta. But maybe we should clear accessibleInfo when editing text?

Unfortunately, for reasons I don't yet understand, Orca is much slower to read than it was when I initially got it working just before FOSDEM. But that doesn't seem related to these changes or to the previous changes made for beta - the alpha was slow in the same way. Could be a result of other changes on my system, so I wouldn't worry about it. Certainly nothing this PR is causing.

Will check Windows next.

MarcSabatella · 2020-06-16T17:55:24Z

Story is the same for NVDA and JAWS - they reads the full text of a text on each cursor movement (after reading the character at cursor).

BTW, some really good news here: JAWS is now reading the new messages for note input mode, adding/removing articulations, and navigation within text. So to me, just clearing the info at the right point in text edit would be great.

Fixes regression caused by commit 3960396 in PR musescore#6173. The accessibleMessage string is cleared in the function AccessibleScoreView::text(), but that function only gets called if there is a screen reader running. If there is no screen reader then accessibleMessage would never be emptied after it was first set, hence currentInfoChanged() was never called to set the status bar text.

Changes: - Display mode text for "Normal mode". - Avoid screen reader output on entering playback mode so that the screen reader does not talk over the music. Also fixes an accessibility bug in commit 3960396 in PR musescore#6173 that caused the screen reader to say "note input mode" periodically rather than just once upon entering that mode. This interfered with the usual screen reader output for that mode, as reported in #306726.

…ifacts Previously the screen reader would say either 'accessibleMessage' or 'accessibleInfo', with priority given to 'accessibleMessage'. Now it will say both strings if they are both are non-empty.

MarcSabatella · 2020-06-17T19:50:08Z

Works great for my with Orca and NVDA.

With JAWS, reading of characters as I cursor through the text is erratic for some reason. It wasn't working at all at first even with your changes, then it seemed it was for a while, now it is reading about half the time, and I can't see a pattern to it. I wouldn't worry about it though, to me this is good to merge.

shoogle · 2020-06-17T22:23:02Z

@MarcSabatella, thanks for the review. @anatoly-os, should be good to go!

Jojo-Schmitz · 2020-06-29T09:46:01Z

mscore/musescore.cpp

@@ -4389,7 +4390,7 @@ void MuseScore::changeState(ScoreState val)
                  showPianoKeyboard(false);
                  break;
            case STATE_NORMAL:
-                  _modeText->hide();
+                  showModeText(tr("Normal mode"));;


This text doesn't show on Transifex, due to string freeze I guess

shoogle force-pushed the status-text branch from a8ffe28 to 1c6d7f8 Compare June 12, 2020 02:27

shoogle commented Jun 12, 2020

View reviewed changes

shoogle force-pushed the status-text branch from 07e6334 to f3b272d Compare June 12, 2020 17:20

shoogle mentioned this pull request Jun 12, 2020

MuseScore 3.5 Release Candidate. PRs to be merged #6195

Closed

1 task

shoogle marked this pull request as draft June 12, 2020 21:38

shoogle force-pushed the status-text branch from 59a8235 to 12bd659 Compare June 15, 2020 16:40

shoogle changed the title ~~fix #306633: Always update status bar text~~ Restore status text and screen reader output Jun 15, 2020

shoogle marked this pull request as ready for review June 15, 2020 16:49

MarcSabatella reviewed Jun 15, 2020

View reviewed changes

shoogle marked this pull request as draft June 16, 2020 19:47

shoogle added 3 commits June 17, 2020 12:34

Screen readers: Say accessible info and message together +collect_art…

628aa6f

…ifacts Previously the screen reader would say either 'accessibleMessage' or 'accessibleInfo', with priority given to 'accessibleMessage'. Now it will say both strings if they are both are non-empty.

shoogle force-pushed the status-text branch from 12bd659 to 628aa6f Compare June 17, 2020 18:15

shoogle marked this pull request as ready for review June 17, 2020 21:36

anatoly-os merged commit 92164b1 into musescore:3.x Jun 20, 2020

shoogle deleted the status-text branch June 22, 2020 11:29

Jojo-Schmitz reviewed Jun 29, 2020

View reviewed changes

shoogle mentioned this pull request Jul 10, 2020

[MU4 Issue] PRs from 3.x to be merged into / ported to master #6079

Closed

29 tasks

anatoly-os added a commit that referenced this pull request Aug 3, 2020

Manually merged #6173, #6210 and #6245 to master

9441dc9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Restore status text and screen reader output #6210

Restore status text and screen reader output #6210

shoogle commented Jun 12, 2020 •

edited

Loading

shoogle Jun 12, 2020

MarcSabatella commented Jun 12, 2020

shoogle commented Jun 12, 2020

MarcSabatella commented Jun 12, 2020

MarcSabatella Jun 15, 2020

shoogle Jun 15, 2020

MarcSabatella Jun 16, 2020

shoogle Jun 17, 2020

anatoly-os commented Jun 16, 2020

MarcSabatella commented Jun 16, 2020

MarcSabatella commented Jun 16, 2020

MarcSabatella commented Jun 16, 2020

MarcSabatella commented Jun 17, 2020

shoogle commented Jun 17, 2020

Jojo-Schmitz Jun 29, 2020 •

edited

Loading

Restore status text and screen reader output #6210

Restore status text and screen reader output #6210

Conversation

shoogle commented Jun 12, 2020 • edited Loading

shoogle Jun 12, 2020

Choose a reason for hiding this comment

MarcSabatella commented Jun 12, 2020

shoogle commented Jun 12, 2020

MarcSabatella commented Jun 12, 2020

MarcSabatella Jun 15, 2020

Choose a reason for hiding this comment

shoogle Jun 15, 2020

Choose a reason for hiding this comment

MarcSabatella Jun 16, 2020

Choose a reason for hiding this comment

shoogle Jun 17, 2020

Choose a reason for hiding this comment

anatoly-os commented Jun 16, 2020

MarcSabatella commented Jun 16, 2020

MarcSabatella commented Jun 16, 2020

MarcSabatella commented Jun 16, 2020

MarcSabatella commented Jun 17, 2020

shoogle commented Jun 17, 2020

Jojo-Schmitz Jun 29, 2020 • edited Loading

Choose a reason for hiding this comment

shoogle commented Jun 12, 2020 •

edited

Loading

Jojo-Schmitz Jun 29, 2020 •

edited

Loading