Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore status text and screen reader output #6210

Merged
merged 3 commits into from
Jun 20, 2020
Merged

Restore status text and screen reader output #6210

merged 3 commits into from
Jun 20, 2020

Commits on Jun 17, 2020

  1. fix #306633: Always update status bar text 

    Fixes regression caused by commit 3960396 in PR musescore#6173.

The accessibleMessage string is cleared in the function
AccessibleScoreView::text(), but that function only gets called if
there is a screen reader running. If there is no screen reader then
accessibleMessage would never be emptied after it was first set, hence
currentInfoChanged() was never called to set the status bar text.
    @shoogle
    shoogle committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    20b6262 View commit details
    Browse the repository at this point in the history

  2. fix #306726: Improve status for playback, note input, and normal modes 

    Changes:

- Display mode text for "Normal mode".

- Avoid screen reader output on entering playback mode so that the
  screen reader does not talk over the music.

Also fixes an accessibility bug in commit 3960396 in PR musescore#6173 that
caused the screen reader to say "note input mode" periodically rather
than just once upon entering that mode. This interfered with the usual
screen reader output for that mode, as reported in #306726.
    @shoogle
    shoogle committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    303bb52 View commit details
    Browse the repository at this point in the history

  3. Screen readers: Say accessible info and message together +collect_art… 

    …ifacts

Previously the screen reader would say either 'accessibleMessage' or
'accessibleInfo', with priority given to 'accessibleMessage'. Now it
will say both strings if they are both are non-empty.
    @shoogle
    shoogle committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    628aa6f View commit details
    Browse the repository at this point in the history