[MU4] Rename note Hooks to Flags, to match SMuFL terms and some more text fixes #6293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
force-pushed
the
hooks-vs-flags-master
branch
3 times, most recently
from
12ccca9
to
bf012c3
Compare
Jojo-Schmitz
force-pushed
the
hooks-vs-flags-master
branch
from
bf012c3
to
03fc31f
Compare
Jojo-Schmitz
changed the title
Jojo-Schmitz
force-pushed
the
hooks-vs-flags-master
branch
from
03fc31f
to
71e9a25
Compare
29 tasks
Jojo-Schmitz
force-pushed
the
hooks-vs-flags-master
branch
from
71e9a25
to
744e57d
Compare
30 tasks
Jojo-Schmitz
force-pushed
the
hooks-vs-flags-master
branch
from
744e57d
to
f17f7f0
Compare
|
The mtests failures are known and unrelated to this PR |
Jojo-Schmitz
force-pushed
the
hooks-vs-flags-master
branch
from
f17f7f0
to
fc3fd9b
Compare
and to differentiate from line hooks
Jojo-Schmitz
force-pushed
the
hooks-vs-flags-master
branch
from
fc3fd9b
to
3167c64
Compare
Jojo-Schmitz
force-pushed
the
hooks-vs-flags-master
branch
from
3167c64
to
4b4d805
Compare
Jojo-Schmitz
changed the title
vpereverzev
approved these changes
Oct 23, 2020
|
Not changing any instances in code variables? |
|
Why? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and to differentiate from line hooks. Also the new Inspector uses "Flag offset" already.
Change some more strings too. Including some that came up as an issue on Transifex.
Counterpart to #6292, but for master