-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mu3] Fix #214996: Add a style option to show measure number range at mmrests #6935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecstrema
force-pushed
the
mm-range
branch
3 times, most recently
from
November 25, 2020 04:35
4aa7bb4
to
181d482
Compare
8 tasks
ecstrema
force-pushed
the
mm-range
branch
3 times, most recently
from
November 25, 2020 06:12
da6e5e9
to
5dd18f6
Compare
ecstrema
changed the title
Add an option to show measure number interval at mmrests
[mu3] Add an option to show measure number interval at mmrests
Nov 25, 2020
ecstrema
force-pushed
the
mm-range
branch
4 times, most recently
from
November 25, 2020 18:52
9546a68
to
bcd32a6
Compare
ecstrema
force-pushed
the
mm-range
branch
2 times, most recently
from
November 26, 2020 17:57
2522f88
to
9a41557
Compare
this one is now ready for review. |
ecstrema
force-pushed
the
mm-range
branch
2 times, most recently
from
November 26, 2020 18:59
855bd02
to
449a631
Compare
The MMRestRange is a new class derived from MeasureNumber. MMRestRange may not be styled like MeasureNumber, so a new set of textstyles were added. There is 3 possible bracketing around the ranges: parentheses, brackets (the default), or none. Logic is handled by Measure::LayoutMMRestRange.
ecstrema
changed the title
[mu3] Add an option to show measure number interval at mmrests
[mu3] Fix #214996: Add an option to show measure number interval at mmrests
Nov 26, 2020
ecstrema
changed the title
[mu3] Fix #214996: Add an option to show measure number interval at mmrests
[mu3] Fix #214996: Add a style option to show measure number range at mmrests
Nov 26, 2020
ecstrema
force-pushed
the
mm-range
branch
2 times, most recently
from
November 27, 2020 04:55
31f332b
to
4f09425
Compare
29 tasks
ecstrema
added a commit
to ecstrema/MuseScore
that referenced
this pull request
Dec 1, 2020
`MeasureNumber`s and `MMRestRange`s were `delete`d in `measure::remove`, which caused a crash when undoing the deletion of these elements.
ecstrema
added a commit
to ecstrema/MuseScore
that referenced
this pull request
Dec 1, 2020
`MeasureNumber`s and `MMRestRange`s were `delete`d in `measure::remove`, which caused a crash when undoing the deletion of these elements.
vpereverzev
pushed a commit
that referenced
this pull request
Dec 2, 2020
`MeasureNumber`s and `MMRestRange`s were `delete`d in `measure::remove`, which caused a crash when undoing the deletion of these elements.
This was referenced Dec 12, 2020
igorkorsukov
added a commit
to igorkorsukov/MuseScore
that referenced
this pull request
Feb 4, 2021
…sure number range at mmrests
igorkorsukov
added a commit
to igorkorsukov/MuseScore
that referenced
this pull request
Feb 4, 2021
…sure number range at mmrests
igorkorsukov
added a commit
to igorkorsukov/MuseScore
that referenced
this pull request
Feb 4, 2021
…sure number range at mmrests
igorkorsukov
added a commit
to igorkorsukov/MuseScore
that referenced
this pull request
Feb 4, 2021
…tion to show measure number range at mmrests
vpereverzev
pushed a commit
that referenced
this pull request
Feb 4, 2021
igorkorsukov
added a commit
to igorkorsukov/MuseScore
that referenced
this pull request
Feb 4, 2021
…tion to show measure number range at mmrests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MMRestRange is a new class derived from MeasureNumber.
There is 3 possible bracketing around the ranges: parentheses, brackets (the default), or none.
rebased version of #6009 (there's a gif demonstrating the thing in the other PR)