Followup for PR #6935, that included a bug. #6987
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MeasureNumber
s andMMRestRange
s weredelete
d inmeasure::remove
,which caused a crash when undoing the deletion of these elements.
Although this may look as a big refactoring for the small issue it solves, it includes a refactoring of the measure number class into a measureNumberBase class, which MMRestRange, as well as MeasureNumber, inherit. So in fact there's only code moving here.
This refactoring should lead to a less errorprone implementation.