-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MU3 Backend] ENG-25: Improve placement defaults #8325
Merged
vpereverzev
merged 1 commit into
musescore:3.6.2_backend
from
iveshenry18:ENG-25-placement-defaults
Jul 6, 2021
Merged
[MU3 Backend] ENG-25: Improve placement defaults #8325
vpereverzev
merged 1 commit into
musescore:3.6.2_backend
from
iveshenry18:ENG-25-placement-defaults
Jul 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oktophonie
approved these changes
Jun 16, 2021
iveshenry18
force-pushed
the
ENG-25-placement-defaults
branch
from
June 22, 2021 17:38
638aba1
to
ace87cb
Compare
rebase needed |
iveshenry18
force-pushed
the
ENG-25-placement-defaults
branch
from
June 29, 2021 00:27
ace87cb
to
a7d66d5
Compare
Rebased! |
vpereverzev
reviewed
Jul 5, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText.
iveshenry18
force-pushed
the
ENG-25-placement-defaults
branch
from
July 6, 2021 03:38
a7d66d5
to
7a02054
Compare
vpereverzev
approved these changes
Jul 6, 2021
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 6, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 6, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325
Jojo-Schmitz
reviewed
Jul 7, 2021
8 tasks
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 13, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 28, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 28, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 13, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 13, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 19, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 19, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 30, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 1, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 2, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 10, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 23, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: ENG-25: Dynamics should appear above vocal staves
This adds some context-aware placement defaults for text and
dynamics (in the case that neither "placement" nor "default-y" nor
"relative-y" are specified). Namely, both expression text and dynamics
are placed below the staff unless it is a vocal staff.
To this end, there are some simple checks added to discern whether a
part is a vocal part, which is currently a simple check against the
name of the staff and a check for the presence of lyrics. Additionally,
the "expression text" is currently defined by the presence of italics in
the
_wordsText
, and an absence of_tempoText
.This PR is built on commits from #8298.