-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MU3 Backend] MusicXML compiler warnings #8554
Merged
vpereverzev
merged 4 commits into
musescore:3.6.2_backend
from
iveshenry18:ENG-various-compiler-warnings
Aug 9, 2021
Merged
[MU3 Backend] MusicXML compiler warnings #8554
vpereverzev
merged 4 commits into
musescore:3.6.2_backend
from
iveshenry18:ENG-various-compiler-warnings
Aug 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 6, 2021
Previously, only the first beam was taken into account when importing Beam::Mode. This commit adds a mechanism to collect the beam type for all beams and make a more correct choice about Beam::Mode (including BEGIN32 and BEGIN64). Additionally, it adds handling of these modes to the export code. Now the round trip from .mscx -> .xml -> .mscx is correct and complete *when beam modes are specified explicitly in the .mscx*; however, more thorough handling of Beam::Mode::AUTO (where it results in the equivalent of BEGIN32 or BEGIN64) on export needs to be done. Duplicate of musescore#8492, plus fixing 4 compiler warnings, see musescore#8554
iveshenry18
changed the title
Add missing parentheses in writeBeam conditional
[MU3 Backend] Add missing parentheses in writeBeam conditional
Jul 7, 2021
iveshenry18
changed the title
[MU3 Backend] Add missing parentheses in writeBeam conditional
[MU3 Backend] MusicXML compiler warnings
Jul 7, 2021
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 13, 2021
Previously, only the first beam was taken into account when importing Beam::Mode. This commit adds a mechanism to collect the beam type for all beams and make a more correct choice about Beam::Mode (including BEGIN32 and BEGIN64). Additionally, it adds handling of these modes to the export code. Now the round trip from .mscx -> .xml -> .mscx is correct and complete *when beam modes are specified explicitly in the .mscx*; however, more thorough handling of Beam::Mode::AUTO (where it results in the equivalent of BEGIN32 or BEGIN64) on export needs to be done. Duplicate of musescore#8492, plus fixing 4 compiler warnings, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 13, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
iveshenry18
force-pushed
the
ENG-various-compiler-warnings
branch
from
July 17, 2021 01:27
fed8e1f
to
e02b9d5
Compare
iveshenry18
force-pushed
the
ENG-various-compiler-warnings
branch
from
July 17, 2021 19:27
e02b9d5
to
15c9dc4
Compare
8 tasks
@@ -4926,7 +4926,7 @@ Note* MusicXMLParserPass2::note(const QString& partId, | |||
else if (_e.name() == "stem") | |||
stem(stemDir, noStem); | |||
else if (_e.name() == "type") { | |||
small = _e.attributes().value("size") == "cue" | _e.attributes().value("size") == "grace-cue"; | |||
small = (_e.attributes().value("size") == "cue") || (_e.attributes().value("size") == "grace-cue"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I was suggesting the parenthezise the entire || expression, not their elements
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 19, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Previously, only the first beam was taken into account when importing Beam::Mode. This commit adds a mechanism to collect the beam type for all beams and make a more correct choice about Beam::Mode (including BEGIN32 and BEGIN64). Additionally, it adds handling of these modes to the export code. Now the round trip from .mscx -> .xml -> .mscx is correct and complete *when beam modes are specified explicitly in the .mscx*; however, more thorough handling of Beam::Mode::AUTO (where it results in the equivalent of BEGIN32 or BEGIN64) on export needs to be done. Duplicate of musescore#8492, plus fixing 4 compiler warnings, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Previously, only the first beam was taken into account when importing Beam::Mode. This commit adds a mechanism to collect the beam type for all beams and make a more correct choice about Beam::Mode (including BEGIN32 and BEGIN64). Additionally, it adds handling of these modes to the export code. Now the round trip from .mscx -> .xml -> .mscx is correct and complete *when beam modes are specified explicitly in the .mscx*; however, more thorough handling of Beam::Mode::AUTO (where it results in the equivalent of BEGIN32 or BEGIN64) on export needs to be done. Duplicate of musescore#8492, plus fixing 4 compiler warnings, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Previously, only the first beam was taken into account when importing Beam::Mode. This commit adds a mechanism to collect the beam type for all beams and make a more correct choice about Beam::Mode (including BEGIN32 and BEGIN64). Additionally, it adds handling of these modes to the export code. Now the round trip from .mscx -> .xml -> .mscx is correct and complete *when beam modes are specified explicitly in the .mscx*; however, more thorough handling of Beam::Mode::AUTO (where it results in the equivalent of BEGIN32 or BEGIN64) on export needs to be done. Duplicate of musescore#8492, plus fixing 4 compiler warnings, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Previously, only the first beam was taken into account when importing Beam::Mode. This commit adds a mechanism to collect the beam type for all beams and make a more correct choice about Beam::Mode (including BEGIN32 and BEGIN64). Additionally, it adds handling of these modes to the export code. Now the round trip from .mscx -> .xml -> .mscx is correct and complete *when beam modes are specified explicitly in the .mscx*; however, more thorough handling of Beam::Mode::AUTO (where it results in the equivalent of BEGIN32 or BEGIN64) on export needs to be done. Duplicate of musescore#8492, plus fixing 4 compiler warnings, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Previously, only the first beam was taken into account when importing Beam::Mode. This commit adds a mechanism to collect the beam type for all beams and make a more correct choice about Beam::Mode (including BEGIN32 and BEGIN64). Additionally, it adds handling of these modes to the export code. Now the round trip from .mscx -> .xml -> .mscx is correct and complete *when beam modes are specified explicitly in the .mscx*; however, more thorough handling of Beam::Mode::AUTO (where it results in the equivalent of BEGIN32 or BEGIN64) on export needs to be done. Duplicate of musescore#8492, plus fixing 4 compiler warnings, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Previously, only the first beam was taken into account when importing Beam::Mode. This commit adds a mechanism to collect the beam type for all beams and make a more correct choice about Beam::Mode (including BEGIN32 and BEGIN64). Additionally, it adds handling of these modes to the export code. Now the round trip from .mscx -> .xml -> .mscx is correct and complete *when beam modes are specified explicitly in the .mscx*; however, more thorough handling of Beam::Mode::AUTO (where it results in the equivalent of BEGIN32 or BEGIN64) on export needs to be done. Duplicate of musescore#8492, plus fixing 4 compiler warnings, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 30, 2021
Previously, only the first beam was taken into account when importing Beam::Mode. This commit adds a mechanism to collect the beam type for all beams and make a more correct choice about Beam::Mode (including BEGIN32 and BEGIN64). Additionally, it adds handling of these modes to the export code. Now the round trip from .mscx -> .xml -> .mscx is correct and complete *when beam modes are specified explicitly in the .mscx*; however, more thorough handling of Beam::Mode::AUTO (where it results in the equivalent of BEGIN32 or BEGIN64) on export needs to be done. Duplicate of musescore#8492, plus fixing 4 compiler warnings, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 30, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 30, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 1, 2021
Add logic to add a space between the words and the metronome marking, if there isn't already a space present at the end of the words. Duplicate of musescore#8284, plus a fix to make it compatible with Qt 5.9 again, see also musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 1, 2021
A common error in exporters is misinterpreting fingerings as word-type directions. This commit adds the MusicXMLInferredFingering and the associated code necessary to detect these directions, find the correct notes to add them to, then add them if such notes are found. The current iteration is able to distribute the fingerings across voices if necessary, as well as round the tick value of a direction to the nearest greatest common denominator of the measure. Duplicate of musescore#8298, part 1, plus 4 fixed compiler warnings, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 1, 2021
Previously, only the first beam was taken into account when importing Beam::Mode. This commit adds a mechanism to collect the beam type for all beams and make a more correct choice about Beam::Mode (including BEGIN32 and BEGIN64). Additionally, it adds handling of these modes to the export code. Now the round trip from .mscx -> .xml -> .mscx is correct and complete *when beam modes are specified explicitly in the .mscx*; however, more thorough handling of Beam::Mode::AUTO (where it results in the equivalent of BEGIN32 or BEGIN64) on export needs to be done. Duplicate of musescore#8492, plus fixing 4 compiler warnings, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 1, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 1, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 2, 2021
Add logic to add a space between the words and the metronome marking, if there isn't already a space present at the end of the words. Duplicate of musescore#8284, plus a fix to make it compatible with Qt 5.9 again, see also musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 2, 2021
A common error in exporters is misinterpreting fingerings as word-type directions. This commit adds the MusicXMLInferredFingering and the associated code necessary to detect these directions, find the correct notes to add them to, then add them if such notes are found. The current iteration is able to distribute the fingerings across voices if necessary, as well as round the tick value of a direction to the nearest greatest common denominator of the measure. Duplicate of musescore#8298, part 1, plus 4 fixed compiler warnings, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 2, 2021
Previously, only the first beam was taken into account when importing Beam::Mode. This commit adds a mechanism to collect the beam type for all beams and make a more correct choice about Beam::Mode (including BEGIN32 and BEGIN64). Additionally, it adds handling of these modes to the export code. Now the round trip from .mscx -> .xml -> .mscx is correct and complete *when beam modes are specified explicitly in the .mscx*; however, more thorough handling of Beam::Mode::AUTO (where it results in the equivalent of BEGIN32 or BEGIN64) on export needs to be done. Duplicate of musescore#8492, plus fixing 4 compiler warnings, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 2, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 2, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 10, 2021
Add logic to add a space between the words and the metronome marking, if there isn't already a space present at the end of the words. Duplicate of musescore#8284, plus a fix to make it compatible with Qt 5.9 again, see also musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 10, 2021
A common error in exporters is misinterpreting fingerings as word-type directions. This commit adds the MusicXMLInferredFingering and the associated code necessary to detect these directions, find the correct notes to add them to, then add them if such notes are found. The current iteration is able to distribute the fingerings across voices if necessary, as well as round the tick value of a direction to the nearest greatest common denominator of the measure. Duplicate of musescore#8298, part 1, plus 4 fixed compiler warnings, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 10, 2021
Previously, only the first beam was taken into account when importing Beam::Mode. This commit adds a mechanism to collect the beam type for all beams and make a more correct choice about Beam::Mode (including BEGIN32 and BEGIN64). Additionally, it adds handling of these modes to the export code. Now the round trip from .mscx -> .xml -> .mscx is correct and complete *when beam modes are specified explicitly in the .mscx*; however, more thorough handling of Beam::Mode::AUTO (where it results in the equivalent of BEGIN32 or BEGIN64) on export needs to be done. Duplicate of musescore#8492, plus fixing 4 compiler warnings, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 10, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 10, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 23, 2021
Add logic to add a space between the words and the metronome marking, if there isn't already a space present at the end of the words. Duplicate of musescore#8284, plus a fix to make it compatible with Qt 5.9 again, see also musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 23, 2021
A common error in exporters is misinterpreting fingerings as word-type directions. This commit adds the MusicXMLInferredFingering and the associated code necessary to detect these directions, find the correct notes to add them to, then add them if such notes are found. The current iteration is able to distribute the fingerings across voices if necessary, as well as round the tick value of a direction to the nearest greatest common denominator of the measure. Duplicate of musescore#8298, part 1, plus 4 fixed compiler warnings, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 23, 2021
Previously, only the first beam was taken into account when importing Beam::Mode. This commit adds a mechanism to collect the beam type for all beams and make a more correct choice about Beam::Mode (including BEGIN32 and BEGIN64). Additionally, it adds handling of these modes to the export code. Now the round trip from .mscx -> .xml -> .mscx is correct and complete *when beam modes are specified explicitly in the .mscx*; however, more thorough handling of Beam::Mode::AUTO (where it results in the equivalent of BEGIN32 or BEGIN64) on export needs to be done. Duplicate of musescore#8492, plus fixing 4 compiler warnings, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 23, 2021
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 23, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
Add logic to add a space between the words and the metronome marking, if there isn't already a space present at the end of the words. Duplicate of musescore#8284, plus a fix to make it compatible with Qt 5.9 again, see also musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
A common error in exporters is misinterpreting fingerings as word-type directions. This commit adds the MusicXMLInferredFingering and the associated code necessary to detect these directions, find the correct notes to add them to, then add them if such notes are found. The current iteration is able to distribute the fingerings across voices if necessary, as well as round the tick value of a direction to the nearest greatest common denominator of the measure. Duplicate of musescore#8298, part 1, plus 4 fixed compiler warnings, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
Previously, only the first beam was taken into account when importing Beam::Mode. This commit adds a mechanism to collect the beam type for all beams and make a more correct choice about Beam::Mode (including BEGIN32 and BEGIN64). Additionally, it adds handling of these modes to the export code. Now the round trip from .mscx -> .xml -> .mscx is correct and complete *when beam modes are specified explicitly in the .mscx*; however, more thorough handling of Beam::Mode::AUTO (where it results in the equivalent of BEGIN32 or BEGIN64) on export needs to be done. Duplicate of musescore#8492, plus fixing 4 compiler warnings, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: Compiler warnings mentioned in #8492, #8325, and #8284