Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU3 Backend] ENG-78 fix spanner offsets #8766

Merged

Commits on Jul 30, 2021

  1. ENG-68: Fix pedal endpoints on other tracks

    Sometimes pedals are imported that begin or end on segments that have
    notes on tracks (or staves) other than the track the spanner is on.
    Previously, this would cause incorrect tick adjustments on "change"
    type pedals, and it would result in some pedals not being able to
    compute a start or end element. This commit fixes these issues by
    considering all tracks of a part when assessing pedal change tick
    adjustments and when computing start elements.
    iveshenry18 committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    86e9930 View commit details
    Browse the repository at this point in the history
  2. ENG-85: Improve tuplet rounding error correction

    MusicXML exporters tend to have a fixed maximum <divisions> value,
    meaning more complex tuplets (5's, 7's) have incorrect duration values.
    These were already handled for tuplets, but sometimes not handled for
    <backup> elements within or after a tuplet.
    
    This commit adds a more thorough system for rounding durations off to
    more sensible values. In doing so, it unifies the conversion process
    from <duration> to Fraction (which previously existed almost identically
    in three separate places) to pass1.calcTicks().
    iveshenry18 committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    aae940d View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2021

  1. ENG-78: fix wedges with <offset> values

    Previously, the <offset> element was not correctly applied to any
    spanners in <direction> elements. This commit fixes that and adjusts the
    applicable tests accordingly.
    iveshenry18 committed Jul 31, 2021
    Configuration menu
    Copy the full SHA
    d22df37 View commit details
    Browse the repository at this point in the history