Allow overriding WASM_BINDGEN_TEST_ADDRESS #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the
wasm-pack test
in headless mode withWASM_BINDGEN_TEST_ADDRESS
environment variable, the default address is set and the URL overriding does not work.https://github.com/rustwasm/wasm-bindgen/blob/4765448545d7bfc0223fd52f25d966b0bfbf8004/crates/cli/src/bin/wasm-bindgen-test-runner/main.rs#L247-L255
As a result, when the test was run with thses arguments, a different port was assigned than the specified in the
WASM_BINDGEN_TEST_ADDRESS
environment variable, and the test will not start forever.To solve this issue, I changed that the
WASM_BINDGEN_TEST_ADDRESS
environment variable is used when it is set, regardless of the headless mode.Links: