Copy port from headless test server when using WASM_BINDGEN_TEST_ADDRESS #3873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4280374.
# Conflicts: # CHANGELOG.md # crates/cli/src/bin/wasm-bindgen-test-runner/headless.rs
lynn
commented
Mar 5, 2024
daxpedda
requested changes
Mar 6, 2024
Co-authored-by: daxpedda <daxpedda@gmail.com>
daxpedda
reviewed
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When putting #3861 to practice, I realized that it's a bit hard to use, because the headless test server might open on a different port every time. It's better to copy the port from the server when it isn't specified. So for example when it happens to open on
127.0.0.1:23456and WASM_BINDGEN_TEST_ADDRESS is set tohttp://localhost.mydomain.orgwe should connect tohttp://localhost.mydomain.org:23456in the test runner (not the default port 80).