Skip to content

Commit

Permalink
fix(editor): Change Home label to Overview (#11736)
Browse files Browse the repository at this point in the history
  • Loading branch information
cstuncsik authored Nov 14, 2024
1 parent 8a0ad0f commit 1a78360
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions cypress/e2e/39-projects.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ describe('Projects', { disableAutoLogin: true }, () => {
let menuItems = cy.getByTestId('menu-item');

menuItems.filter('[class*=active_]').should('have.length', 1);
menuItems.filter(':contains("Home")[class*=active_]').should('exist');
menuItems.filter(':contains("Overview")[class*=active_]').should('exist');

projects.getMenuItems().first().click();

Expand Down Expand Up @@ -222,15 +222,15 @@ describe('Projects', { disableAutoLogin: true }, () => {
menuItems = cy.getByTestId('menu-item');

menuItems.filter('[class*=active_]').should('have.length', 1);
menuItems.filter(':contains("Home")[class*=active_]').should('exist');
menuItems.filter(':contains("Overview")[class*=active_]').should('exist');

workflowsPage.getters.workflowCards().should('have.length', 2).first().click();

cy.wait('@loadWorkflow');
cy.getByTestId('execute-workflow-button').should('be.visible');

menuItems = cy.getByTestId('menu-item');
menuItems.filter(':contains("Home")[class*=active_]').should('not.exist');
menuItems.filter(':contains("Overview")[class*=active_]').should('not.exist');

menuItems = cy.getByTestId('menu-item');
menuItems.filter('[class*=active_]').should('have.length', 1);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ describe('ProjectHeader', () => {
it('should render the correct title', async () => {
const { getByText, rerender } = renderComponent();

expect(getByText('Home')).toBeVisible();
expect(getByText('Overview')).toBeVisible();

projectsStore.currentProject = { type: ProjectTypes.Personal } as Project;
await rerender({});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const headerIcon = computed(() => {
const projectName = computed(() => {
if (!projectsStore.currentProject) {
return i18n.baseText('projects.menu.home');
return i18n.baseText('projects.menu.overview');
} else if (projectsStore.currentProject.type === ProjectTypes.Personal) {
return i18n.baseText('projects.menu.personal');
} else {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const isCreatingProject = ref(false);
const isComponentMounted = ref(false);
const home = computed<IMenuItem>(() => ({
id: 'home',
label: locale.baseText('projects.menu.home'),
label: locale.baseText('projects.menu.overview'),
icon: 'home',
route: {
to: { name: VIEWS.HOMEPAGE },
Expand Down
2 changes: 1 addition & 1 deletion packages/editor-ui/src/plugins/i18n/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -2499,7 +2499,7 @@
"settings.mfa.title": "Multi-factor Authentication",
"settings.mfa.updateConfiguration": "MFA configuration updated",
"settings.mfa.invalidAuthenticatorCode": "Invalid authenticator code",
"projects.menu.home": "Home",
"projects.menu.overview": "Overview",
"projects.menu.title": "Projects",
"projects.menu.personal": "Personal",
"projects.menu.addProject": "Add project",
Expand Down

0 comments on commit 1a78360

Please sign in to comment.