Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Change Home label to Overview #11736

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

cstuncsik
Copy link
Contributor

@cstuncsik cstuncsik commented Nov 14, 2024

Summary

According to some users, Overview is more appropriate for the section that shows all workflows, credentials and executions they have access to

Related Linear tickets, Github issues, and Community forum posts

PAY-2223

Review / Merge checklist

  • PR title and summary are descriptive.
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 14, 2024
Copy link

cypress bot commented Nov 14, 2024

n8n    Run #7880

Run Properties:  status check passed Passed #7880  •  git commit 2d1b4c2b31: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Project n8n
Branch Review pay-2223-change-name-of-home-menu-item-to-overview
Run status status check passed Passed #7880
Run duration 04m 40s
Commit git commit 2d1b4c2b31: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Committer Csaba Tuncsik
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 470
View all changes introduced in this branch ↗︎

@cstuncsik cstuncsik marked this pull request as ready for review November 14, 2024 12:29
@cstuncsik cstuncsik requested a review from r00gm November 14, 2024 12:30
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@r00gm r00gm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but shouldn't we also change the URL ??

Copy link
Contributor

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik merged commit 1a78360 into master Nov 14, 2024
56 checks passed
@cstuncsik cstuncsik deleted the pay-2223-change-name-of-home-menu-item-to-overview branch November 14, 2024 12:59
@cstuncsik
Copy link
Contributor Author

cstuncsik commented Nov 14, 2024

@r00gm

Approved but shouldn't we also change the URL ??

They said not (at least not yet)

@github-actions github-actions bot mentioned this pull request Nov 20, 2024
@janober
Copy link
Member

janober commented Nov 20, 2024

Got released with n8n@1.69.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants