fix(core): Use consistent timezone-aware timestamps in postgres #6948

netroy · 2023-08-16T18:18:59Z

Fixes:

Supersedes #2813

DB Tests

github-actions · 2023-08-16T18:19:29Z

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

If fixing bug, added test to cover scenario.
If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

Added unit tests to cover new or updated functionality.

Files matching packages/cli/src/databases/migrations/**:

Requested review from at least two engineers on migration.
Avoided irreversible data migrations.
Avoided deleting or updating data keys.
Wrote 'down' migration if possible.

Make sure to check off this list before asking for review.

packages/cli/src/databases/entities/AbstractEntity.ts

codecov · 2023-08-16T18:36:29Z

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d936ca0) 32.98% compared to head (cddff4d) 31.99%.
Report is 1 commits behind head on master.

❗ Current head cddff4d differs from pull request most recent head 9d0b8f5. Consider uploading reports for the commit 9d0b8f5 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6948      +/-   ##
==========================================
- Coverage   32.98%   31.99%   -0.99%     
==========================================
  Files        3358     3277      -81     
  Lines      200231   197963    -2268     
  Branches    21974    21592     -382     
==========================================
- Hits        66048    63341    -2707     
- Misses     133074   133561     +487     
+ Partials     1109     1061      -48

Files	Coverage Δ
...kages/cli/src/databases/entities/AbstractEntity.ts	`83.33% <100.00%> (-0.67%)`	⬇️

... and 233 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ivov

Thanks for taking this on! Reviewed but untested.

...es/cli/src/databases/migrations/postgresdb/1692207852593-MigrateToTimestampZ1692207852593.ts

packages/cli/src/databases/migrations/postgresdb/index.ts

...es/cli/src/databases/migrations/postgresdb/1692207852593-MigrateToTimestampZ1692207852593.ts

krynble

The odd part is that now there seems to be some inconsistency in the app.

Wait node works like a charm.

A workflow that I just edited now shows for instance "Edited 2 hours ago" since we are GMT-2. But the same does not happen for creds.

netroy · 2023-08-28T13:56:23Z

The odd part is that now there seems to be some inconsistency in the app.

Wait node works like a charm.

A workflow that I just edited now shows for instance "Edited 2 hours ago" since we are GMT-2. But the same does not happen for creds.

I'm unfortunately unable to reproduce this. I've rebased and rebuilt this branch twice in the last week, and each time new credentials and new workflows showed the correct timestamp in the UI.

packages/cli/src/databases/entities/AbstractEntity.ts

krynble

I couldn't reproduce the issue anymore as well, maybe I was doing something wrong.

LGTM! Thanks for the fix.

cypress · 2023-09-07T13:49:35Z

Passing run #2303 ↗︎

0	242	3	0	0

Details:

🌳 fix-ENG-51-PAY-397 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n	Commit: `9d0b8f5c1e`
Status: Passed	Duration: 08:29 💡
Started: Sep 27, 2023 4:22 PM	Ended: Sep 27, 2023 4:30 PM

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}

github-actions · 2023-09-07T13:49:42Z

✅ All Cypress E2E specs passed

Fixes: * ENG-51 / N8N-2490 * PAY-397 * #2178 * #2810 * #3855 Supersedes #2813

github-actions · 2023-09-27T16:13:59Z

⚠️ Some Cypress E2E specs are failing, please fix them before merging

github-actions · 2023-09-27T16:30:37Z

✅ All Cypress E2E specs passed

# [1.9.0](https://github.com/n8n-io/n8n/compare/n8n@1.8.0...n8n@1.9.0) (2023-09-28) ### Bug Fixes * **Airtable Node:** Attachments field type fix ([#7227](#7227)) ([2af967c](2af967c)) * **core:** Change WorkflowHistory nodes/connections columns to be json ([#7282](#7282)) ([a80abad](a80abad)) * **core:** Fix binary data manager check on pruning ([#7251](#7251)) ([484035e](484035e)) * **core:** Fix missing execution ID in webhook-based workflow producing binary data ([#7244](#7244)) ([33991e9](33991e9)) * **core:** Handle filename* with quotes in Content-Disposition header ([#7229](#7229)) ([67b985f](67b985f)) * **core:** Make DNS resolution order configurable ([#7272](#7272)) ([5b3121c](5b3121c)) * **core:** Make senderId required for all command messages ([#7252](#7252)) ([4b01428](4b01428)) * **core:** Prevent executions from displaying Running status incorrectly ([#7261](#7261)) ([861cac5](861cac5)) * **core:** Use consistent timezone-aware timestamps in postgres ([#6948](#6948)) ([0132514](0132514)), closes [#2178](#2178) [#2810](#2810) [#3855](#3855) [#2813](#2813) * **editor:** Add debug feature docs link ([#7240](#7240)) ([4614e1e](4614e1e)) * **editor:** Fix SQL editor issue ([#7236](#7236)) ([647fc6c](647fc6c)) * **editor:** Ensure new Set node is on top of search list ([#7215](#7215)) ([2491ccf](2491ccf)) * **editor:** Forbid password reset when cloud account is limited in the number of users [7188](#7188) ([303bc8e](303bc8e)) * **HTTP Request Node:** Add suggestion how to fix '429 - too many requests' errors ([#7293](#7293)) ([0bc33b1](0bc33b1)) * **Item Lists Node:** Concatenate operation pairedItems fix ([#7286](#7286)) ([cde23a1](cde23a1)) * **Respond to Webhook Node:** JSON output from expression fix ([#7294](#7294)) ([8bc369d](8bc369d)) ### Features * Add onboarding flow ([#7212](#7212)) ([01e9340](01e9340)) * **core:** Add secrets provider reload and refactor ([#7277](#7277)) ([53a7502](53a7502)) * **core:** Add Tournament as the new default expression evaluator ([#6964](#6964)) ([bf74f09](bf74f09)) * **core:** Initial workflow history API ([#7234](#7234)) ([0083a9e](0083a9e)) * **core:** Introduce object store service ([#7225](#7225)) ([fa84545](fa84545)) * **editor:** Add user cloud ID to telemetry [#7232](#7232) ([60c152d](60c152d)) * **editor:** Rework banners framework and add email confirmation banner ([#7205](#7205)) ([b0e98b5](b0e98b5)) * **MISP Node:** Update credential to support HTTP Request node ([#7268](#7268)) ([e4c302c](e4c302c)) ### Performance Improvements * **core:** Skip unneeded calls on every pruning cycle ([#7260](#7260)) ([db01164](db01164)) Co-authored-by: netroy <netroy@users.noreply.github.com>

janober · 2023-09-28T16:19:23Z

Got released with n8n@1.9.0

Fixes: * ENG-51 / N8N-2490 * PAY-397 * #2178 * #2810 * #3855 Supersedes #2813 [DB Tests](https://github.com/n8n-io/n8n/actions/runs/6000780146/job/16273596338)

netroy requested a review from a team as a code owner August 16, 2023 18:18

netroy force-pushed the fix-ENG-51-PAY-397 branch from 89d9ab0 to 67c0367 Compare August 16, 2023 18:19

n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Aug 16, 2023

netroy commented Aug 16, 2023

View reviewed changes

packages/cli/src/databases/entities/AbstractEntity.ts Outdated Show resolved Hide resolved

ivov reviewed Aug 17, 2023

View reviewed changes

netroy force-pushed the fix-ENG-51-PAY-397 branch from 0c117c2 to e132514 Compare August 17, 2023 11:26

netroy requested a review from krynble August 17, 2023 13:35

krynble suggested changes Aug 21, 2023

View reviewed changes

netroy force-pushed the fix-ENG-51-PAY-397 branch 2 times, most recently from be390dd to f2e18a1 Compare August 28, 2023 13:55

netroy requested a review from krynble August 28, 2023 13:56

netroy commented Aug 28, 2023

View reviewed changes

packages/cli/src/databases/entities/AbstractEntity.ts Outdated Show resolved Hide resolved

krynble previously approved these changes Aug 30, 2023

View reviewed changes

netroy dismissed krynble’s stale review via d22467d September 7, 2023 13:09

netroy force-pushed the fix-ENG-51-PAY-397 branch from c1bd866 to d22467d Compare September 7, 2023 13:09

netroy requested a review from krynble September 7, 2023 13:09

netroy force-pushed the fix-ENG-51-PAY-397 branch from d22467d to cddff4d Compare September 7, 2023 13:24

krynble previously approved these changes Sep 7, 2023

View reviewed changes

netroy dismissed krynble’s stale review via e762bd9 September 14, 2023 13:56

netroy force-pushed the fix-ENG-51-PAY-397 branch 2 times, most recently from e762bd9 to 1c0ddc5 Compare September 20, 2023 10:32

netroy force-pushed the fix-ENG-51-PAY-397 branch from 1c0ddc5 to 433aa05 Compare September 25, 2023 10:35

fix(core): Use consistent timezone-aware timestamps in postgres

9d0b8f5

Fixes: * ENG-51 / N8N-2490 * PAY-397 * #2178 * #2810 * #3855 Supersedes #2813

netroy force-pushed the fix-ENG-51-PAY-397 branch from 433aa05 to 9d0b8f5 Compare September 27, 2023 12:57

netroy requested a review from krynble September 27, 2023 12:57

krynble approved these changes Sep 27, 2023

View reviewed changes

netroy merged commit 0132514 into master Sep 27, 2023
18 checks passed

netroy deleted the fix-ENG-51-PAY-397 branch September 27, 2023 16:44

netroy mentioned this pull request Sep 27, 2023

Fix timezone issue on Postgres (issues: #2810 and #2178) #2813

Closed

github-actions bot mentioned this pull request Sep 28, 2023

🚀 Release 1.9.0 #7288

Merged

janober added the Released label Sep 28, 2023

netroy mentioned this pull request Oct 17, 2023

Fix date check in waittracker #6913

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(core): Use consistent timezone-aware timestamps in postgres #6948

fix(core): Use consistent timezone-aware timestamps in postgres #6948

netroy commented Aug 16, 2023 •

edited

Loading

github-actions bot commented Aug 16, 2023

codecov bot commented Aug 16, 2023 •

edited

Loading

ivov left a comment

krynble left a comment

netroy commented Aug 28, 2023

krynble left a comment

cypress bot commented Sep 7, 2023 •

edited

Loading

github-actions bot commented Sep 7, 2023

github-actions bot commented Sep 27, 2023

github-actions bot commented Sep 27, 2023

janober commented Sep 28, 2023

fix(core): Use consistent timezone-aware timestamps in postgres #6948

fix(core): Use consistent timezone-aware timestamps in postgres #6948

Conversation

netroy commented Aug 16, 2023 • edited Loading

github-actions bot commented Aug 16, 2023

codecov bot commented Aug 16, 2023 • edited Loading

Codecov Report

ivov left a comment

Choose a reason for hiding this comment

krynble left a comment

Choose a reason for hiding this comment

netroy commented Aug 28, 2023

krynble left a comment

Choose a reason for hiding this comment

cypress bot commented Sep 7, 2023 • edited Loading

Passing run #2303 ↗︎

github-actions bot commented Sep 7, 2023

github-actions bot commented Sep 27, 2023

github-actions bot commented Sep 27, 2023

janober commented Sep 28, 2023

netroy commented Aug 16, 2023 •

edited

Loading

codecov bot commented Aug 16, 2023 •

edited

Loading

cypress bot commented Sep 7, 2023 •

edited

Loading