-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): Standardize filenames in cli
(no-changelog)
#10484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quick first pass to rename most files in `cli` to kebab-case. Following dirs to be included in next pass: - `cli/src/controllers` - `cli/src/databases` - `cli/src/environments` - `cli/src/eventbus` - `cli/src/PublicApi` - `cli/src/services` - `cli/test`
Locally it builds and tests fine so this looks CI-only, I'll take a look tomorrow. |
n8n-assistant
bot
added
core
Enhancement outside /nodes-base and /editor-ui
n8n team
Authored by the n8n team
labels
Aug 20, 2024
netroy
previously approved these changes
Aug 21, 2024
✅ All Cypress E2E specs passed |
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
netroy
approved these changes
Aug 22, 2024
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Aug 22, 2024
* master: ci: Fix benchmark cli path (no-changelog) (#10506) refactor(core): Standardize filenames in `cli` (no-changelog) (#10484) fix(AI Agent Node): Allow AWS Bedrock Chat to be used with conversational agent (#10489) feat(AI Agent Node): Add tutorial link to agent node (#10493) feat: Add n8n-benchmark cli (no-changelog) (#10410) feat(core): Logout should invalidate the auth token (no-changelog) (#10335) refactor(editor): Add types to importCurlEventBus (no-changelog) (#10497) refactor(editor): Add types to htmlEditorEventBus (no-changelog) (#10498) refactor(editor): Add types for dataPinningEventBus (no-changelog) (#10499) refactor(editor): Add types to codeNodeEditorEventBus (no-changelog) (#10501)
ivov
added a commit
that referenced
this pull request
Aug 23, 2024
…tbus (no-changelog) Follow-up to: #10484 Pending for next pass: - `cli/src/controllers` - `cli/src/databases` - `cli/src/PublicApi` - `cli/src/services` - `cli/test`
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick first pass to rename most files in
cli
to kebab-case.Following dirs to be included in next pass:
cli/src/controllers
cli/src/databases
cli/src/environments
cli/src/eventbus
cli/src/PublicApi
cli/src/services
cli/test