Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Standardize filenames in cli (no-changelog) #10484

Merged
merged 7 commits into from
Aug 22, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Aug 20, 2024

Quick first pass to rename most files in cli to kebab-case.

Following dirs to be included in next pass:

  • cli/src/controllers
  • cli/src/databases
  • cli/src/environments
  • cli/src/eventbus
  • cli/src/PublicApi
  • cli/src/services
  • cli/test

Quick first pass to rename most files in `cli` to kebab-case.

Following dirs to be included in next pass:

- `cli/src/controllers`
- `cli/src/databases`
- `cli/src/environments`
- `cli/src/eventbus`
- `cli/src/PublicApi`
- `cli/src/services`
- `cli/test`
@ivov ivov requested a review from a team as a code owner August 20, 2024 16:50
@ivov ivov marked this pull request as draft August 20, 2024 16:51
@ivov
Copy link
Contributor Author

ivov commented Aug 20, 2024

Locally it builds and tests fine so this looks CI-only, I'll take a look tomorrow.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Aug 20, 2024
netroy
netroy previously approved these changes Aug 21, 2024
@netroy netroy marked this pull request as ready for review August 21, 2024 08:01
Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Aug 21, 2024



Test summary

414 0 0 0Flakiness 0


Run details

Project n8n
Status Passed
Commit dac7be5
Started Aug 22, 2024 9:00 AM
Ended Aug 22, 2024 9:05 AM
Duration 04:49 💡
OS Linux Debian -
Browser Electron 118

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit f667b38 into master Aug 22, 2024
33 checks passed
@ivov ivov deleted the standardize-filenames-in-cli-first-pass branch August 22, 2024 09:10
MiloradFilipovic added a commit that referenced this pull request Aug 22, 2024
* master:
  ci: Fix benchmark cli path (no-changelog) (#10506)
  refactor(core): Standardize filenames in `cli` (no-changelog) (#10484)
  fix(AI Agent Node): Allow AWS Bedrock Chat to be used with conversational agent (#10489)
  feat(AI Agent Node): Add tutorial link to agent node (#10493)
  feat: Add n8n-benchmark cli (no-changelog) (#10410)
  feat(core): Logout should invalidate the auth token (no-changelog) (#10335)
  refactor(editor): Add types to importCurlEventBus (no-changelog) (#10497)
  refactor(editor): Add types to htmlEditorEventBus (no-changelog) (#10498)
  refactor(editor): Add types for dataPinningEventBus (no-changelog) (#10499)
  refactor(editor): Add types to codeNodeEditorEventBus (no-changelog) (#10501)
ivov added a commit that referenced this pull request Aug 23, 2024
…tbus (no-changelog)

Follow-up to: #10484

Pending for next pass:
- `cli/src/controllers`
- `cli/src/databases`
- `cli/src/PublicApi`
- `cli/src/services`
- `cli/test`
@janober
Copy link
Member

janober commented Aug 28, 2024

Got released with n8n@1.57.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants