Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): Add types to importCurlEventBus (no-changelog) #10497

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

tomi
Copy link
Contributor

@tomi tomi commented Aug 21, 2024

Summary

Add types to importCurlEventBus

Related Linear tickets, Github issues, and Community forum posts

CAT-32

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Aug 21, 2024
Copy link
Contributor

@RicardoE105 RicardoE105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Aug 21, 2024



Test summary

414 0 0 0Flakiness 1


Run details

Project n8n
Status Passed
Commit 9ab6dde
Started Aug 21, 2024 11:17 PM
Ended Aug 21, 2024 11:22 PM
Duration 04:48 💡
OS Linux Debian -
Browser Electron 118

View run in Cypress Cloud ➡️


Flakiness

e2e/30-langchain.cy.ts Flakiness
1 Langchain Integration > should be able to open and execute Basic LLM Chain node

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@tomi tomi merged commit b805e8d into master Aug 22, 2024
27 checks passed
@tomi tomi deleted the cat-38-importcurleventbus branch August 22, 2024 06:32
MiloradFilipovic added a commit that referenced this pull request Aug 22, 2024
* master:
  ci: Fix benchmark cli path (no-changelog) (#10506)
  refactor(core): Standardize filenames in `cli` (no-changelog) (#10484)
  fix(AI Agent Node): Allow AWS Bedrock Chat to be used with conversational agent (#10489)
  feat(AI Agent Node): Add tutorial link to agent node (#10493)
  feat: Add n8n-benchmark cli (no-changelog) (#10410)
  feat(core): Logout should invalidate the auth token (no-changelog) (#10335)
  refactor(editor): Add types to importCurlEventBus (no-changelog) (#10497)
  refactor(editor): Add types to htmlEditorEventBus (no-changelog) (#10498)
  refactor(editor): Add types for dataPinningEventBus (no-changelog) (#10499)
  refactor(editor): Add types to codeNodeEditorEventBus (no-changelog) (#10501)
@janober
Copy link
Member

janober commented Aug 28, 2024

Got released with n8n@1.57.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants