Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): Standardize components sections order (no-changelog) #10540

Merged
merged 6 commits into from
Aug 24, 2024

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Aug 23, 2024

Summary

  • Standardize components section order.
  • Add a linting rule (vue/block-order) to enforce the section order from now on.

Review / Merge checklist

@RicardoE105 RicardoE105 changed the title standardize components sections order refactor(editor): standardize components sections order (no-changelog) Aug 23, 2024
@RicardoE105 RicardoE105 changed the title refactor(editor): standardize components sections order (no-changelog) refactor(editor): Standardize components sections order (no-changelog) Aug 23, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Aug 23, 2024
@RicardoE105 RicardoE105 requested a review from alexgrozav August 23, 2024 17:48
alexgrozav
alexgrozav previously approved these changes Aug 23, 2024
Copy link

cypress bot commented Aug 23, 2024

n8n    Run #6600

Run Properties:  status check passed Passed #6600  •  git commit 609bc4d97d: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project n8n
Branch Review master
Run status status check passed Passed #6600
Run duration 04m 50s
Commit git commit 609bc4d97d: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Committer Ricardo Espinoza
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 419
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link
Member

@alexgrozav alexgrozav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this 🙏

Copy link
Contributor

✅ All Cypress E2E specs passed

@RicardoE105 RicardoE105 merged commit 609bc4d into master Aug 24, 2024
32 checks passed
@RicardoE105 RicardoE105 deleted the standardize-components-sections-order branch August 24, 2024 13:24
MiloradFilipovic added a commit that referenced this pull request Aug 26, 2024
* master:
  ci: Use correct env in destroy benchmark env job (no-changelog) (#10546)
  refactor(editor): Standardize components sections order (no-changelog) (#10540)
  refactor(editor): Convert Node.vue component to composition API (no-changelog) (#10535)
  feat: Add new credentials for the HTTP Request node (#9833)
  fix: Pass k6 api token correctly (no-changelog) (#10536)
  feat: Report benchmark results (no-changelog) (#10534)
  test(editor): Unit tests for assistant store and new design system components (no-changelog) (#10508)
  refactor(editor): Migrate `App.vue` to composition api (no-changelog) (#10524)
  refactor(editor): Convert DeleteUserModal to composition api (no-changelog) (#10531)
  ci: Fix fetch depth in benchmark (no-changelog) (#10532)
  ci: Use correct env for benchmark nightly workflow (no-changelog) (#10529)
  fix(core): Update zod to the latest version (no-changelog) (#10516)
  feat: Benchmark env with run scripts (no-changelog) (#10477)
  ci: Configure eslint for benchmark cli (#10480)
  fix(AI Transform Node): Data Transformation > Other section should not contain node (no-changelog) (#10519)
  fix(editor): Prevent dialog overlay from rendering on top of AI Assistant (no-changelog) (#10509)
  fix: Fix resolving of k6 executable (no-changelog) (#10511)
  fix(core): Restore Redis cache key (#10520)

# Conflicts:
#	packages/editor-ui/src/App.vue
#	packages/editor-ui/src/components/AskAssistant/AskAssistantChat.vue
#	packages/editor-ui/src/components/Modal.vue
#	packages/editor-ui/src/components/NodeDetailsView.vue
@janober
Copy link
Member

janober commented Aug 28, 2024

Got released with n8n@1.57.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants