-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(editor): Standardize components sections order (no-changelog) #10540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicardoE105
changed the title
standardize components sections order
refactor(editor): standardize components sections order (no-changelog)
Aug 23, 2024
RicardoE105
changed the title
refactor(editor): standardize components sections order (no-changelog)
refactor(editor): Standardize components sections order (no-changelog)
Aug 23, 2024
n8n-assistant
bot
added
n8n team
Authored by the n8n team
ui
Enhancement in /editor-ui or /design-system
labels
Aug 23, 2024
alexgrozav
previously approved these changes
Aug 23, 2024
n8n Run #6600
Run Properties:
|
Project |
n8n
|
Branch Review |
master
|
Run status |
Passed #6600
|
Run duration | 04m 50s |
Commit |
609bc4d97d: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
|
Committer | Ricardo Espinoza |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
419
|
View all changes introduced in this branch ↗︎ |
✅ All Cypress E2E specs passed |
alexgrozav
approved these changes
Aug 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this 🙏
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Aug 26, 2024
* master: ci: Use correct env in destroy benchmark env job (no-changelog) (#10546) refactor(editor): Standardize components sections order (no-changelog) (#10540) refactor(editor): Convert Node.vue component to composition API (no-changelog) (#10535) feat: Add new credentials for the HTTP Request node (#9833) fix: Pass k6 api token correctly (no-changelog) (#10536) feat: Report benchmark results (no-changelog) (#10534) test(editor): Unit tests for assistant store and new design system components (no-changelog) (#10508) refactor(editor): Migrate `App.vue` to composition api (no-changelog) (#10524) refactor(editor): Convert DeleteUserModal to composition api (no-changelog) (#10531) ci: Fix fetch depth in benchmark (no-changelog) (#10532) ci: Use correct env for benchmark nightly workflow (no-changelog) (#10529) fix(core): Update zod to the latest version (no-changelog) (#10516) feat: Benchmark env with run scripts (no-changelog) (#10477) ci: Configure eslint for benchmark cli (#10480) fix(AI Transform Node): Data Transformation > Other section should not contain node (no-changelog) (#10519) fix(editor): Prevent dialog overlay from rendering on top of AI Assistant (no-changelog) (#10509) fix: Fix resolving of k6 executable (no-changelog) (#10511) fix(core): Restore Redis cache key (#10520) # Conflicts: # packages/editor-ui/src/App.vue # packages/editor-ui/src/components/AskAssistant/AskAssistantChat.vue # packages/editor-ui/src/components/Modal.vue # packages/editor-ui/src/components/NodeDetailsView.vue
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
vue/block-order
) to enforce the section order from now on.Review / Merge checklist