Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use correct env in destroy benchmark env job (no-changelog) #10546

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

tomi
Copy link
Contributor

@tomi tomi commented Aug 26, 2024

Summary

Similar to #10529

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link

cypress bot commented Aug 26, 2024

n8n    Run #6604

Run Properties:  status check passed Passed #6604  •  git commit cb3bd326aa: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 tomi 🗃️ e2e/*
Project n8n
Branch Review fix-gh-actions-environment
Run status status check passed Passed #6604
Run duration 04m 51s
Commit git commit cb3bd326aa: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 tomi 🗃️ e2e/*
Committer Tomi Turtiainen
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 419
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@tomi tomi merged commit cd0c6d9 into master Aug 26, 2024
33 checks passed
@tomi tomi deleted the fix-gh-actions-environment branch August 26, 2024 06:58
MiloradFilipovic added a commit that referenced this pull request Aug 26, 2024
* master:
  ci: Use correct env in destroy benchmark env job (no-changelog) (#10546)
  refactor(editor): Standardize components sections order (no-changelog) (#10540)
  refactor(editor): Convert Node.vue component to composition API (no-changelog) (#10535)
  feat: Add new credentials for the HTTP Request node (#9833)
  fix: Pass k6 api token correctly (no-changelog) (#10536)
  feat: Report benchmark results (no-changelog) (#10534)
  test(editor): Unit tests for assistant store and new design system components (no-changelog) (#10508)
  refactor(editor): Migrate `App.vue` to composition api (no-changelog) (#10524)
  refactor(editor): Convert DeleteUserModal to composition api (no-changelog) (#10531)
  ci: Fix fetch depth in benchmark (no-changelog) (#10532)
  ci: Use correct env for benchmark nightly workflow (no-changelog) (#10529)
  fix(core): Update zod to the latest version (no-changelog) (#10516)
  feat: Benchmark env with run scripts (no-changelog) (#10477)
  ci: Configure eslint for benchmark cli (#10480)
  fix(AI Transform Node): Data Transformation > Other section should not contain node (no-changelog) (#10519)
  fix(editor): Prevent dialog overlay from rendering on top of AI Assistant (no-changelog) (#10509)
  fix: Fix resolving of k6 executable (no-changelog) (#10511)
  fix(core): Restore Redis cache key (#10520)

# Conflicts:
#	packages/editor-ui/src/App.vue
#	packages/editor-ui/src/components/AskAssistant/AskAssistantChat.vue
#	packages/editor-ui/src/components/Modal.vue
#	packages/editor-ui/src/components/NodeDetailsView.vue
@janober
Copy link
Member

janober commented Aug 28, 2024

Got released with n8n@1.57.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants