Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Unify disabled parameters background color #12306

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix(editor): Unify disabled parameters background color #12306

merged 1 commit into from
Dec 19, 2024

Conversation

OlegIvaniv
Copy link
Contributor

Summary

  • Fix inconsistent disabled parameters background colors
  • Fix passing of is-read-only prop to WorkflowSelectorParameterInput
  • Removed --disabled-fill: var(--color-background-base); from InlineExpressionEditorInput as we're setting it on root list level(parameter-input-list-wrapper).
    CleanShot 2024-12-19 at 12 58 22
    CleanShot 2024-12-19 at 12 58 07

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 19, 2024
@cypress Cypress
Copy link

cypress bot commented Dec 19, 2024

n8n    Run #8417

Run Properties:  status check passed Passed #8417  •  git commit fb9c3524f7: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Project n8n
Branch Review disabled_colors_consistency
Run status status check passed Passed #8417
Run duration 04m 32s
Commit git commit fb9c3524f7: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Committer Oleg Ivaniv
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 480
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ckages/editor-ui/src/components/ParameterInput.vue 0.00% 1 Missing ⚠️
...rParameterInput/WorkflowSelectorParameterInput.vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@OlegIvaniv OlegIvaniv merged commit 8c63599 into master Dec 19, 2024
37 checks passed
@OlegIvaniv OlegIvaniv deleted the disabled_colors_consistency branch December 19, 2024 16:42
riascho pushed a commit that referenced this pull request Dec 23, 2024
@OlegIvaniv @riascho
fix(editor): Unify disabled parameters background color (#12306)
87df37c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgrozav alexgrozav alexgrozav approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OlegIvaniv @alexgrozav