Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Unify disabled parameters background color #12306

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix(editor): Unify disabled parameters background color #12306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions packages/editor-ui/src/components/InlineExpressionEditor/InlineExpressionEditorInput.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,27 +114,14 @@ defineExpose({
</script>

<template>
<div
ref="root"
title=""
:class="$style.editor"
data-test-id="inline-expression-editor-input"
></div>
<div ref="root" title="" data-test-id="inline-expression-editor-input"></div>
</template>

<style lang="scss" module>
.editor div[contenteditable='false'] {
background-color: var(--disabled-fill, var(--color-background-light));
cursor: not-allowed;
}
</style>

<style lang="scss" scoped>
:deep(.cm-editor) {
padding-left: 0;
}
:deep(.cm-content) {
--disabled-fill: var(--color-background-base);
padding-left: var(--spacing-2xs);
&[aria-readonly='true'] {
Expand Down
1 change: 1 addition & 0 deletions packages/editor-ui/src/components/ParameterInput.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1059,6 +1059,7 @@ onUpdated(async () => {
:expression-edit-dialog-visible="expressionEditDialogVisible"
:path="path"
:parameter-issues="getIssues"
:is-read-only="isReadOnly"
@update:model-value="valueChanged"
@modal-opener-click="openExpressionEditorModal"
@focus="setFocus"
Expand Down
1 change: 1 addition & 0 deletions packages/editor-ui/src/components/ParameterInputList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,6 +650,7 @@ function getParameterValue<T extends NodeParameterValueType = NodeParameterValue

<style lang="scss">
.parameter-input-list-wrapper {
--disabled-fill: var(--color-background-base);
.icon-button {
position: absolute;
opacity: 0;
Expand Down
1 change: 1 addition & 0 deletions ...ditor-ui/src/components/WorkflowSelectorParameterInput/WorkflowSelectorParameterInput.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,7 @@ const onAddResourceClicked = () => {
ref="input"
:model-value="expressionDisplayValue"
:path="path"
:is-read-only="isReadOnly"
:rows="3"
@update:model-value="onInputChange"
@modal-opener-click="emit('modalOpenerClick')"
Expand Down
Loading