Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
/users
tests for user management backend #2790Add
/users
tests for user management backend #2790Changes from 28 commits
5ae6b3f
eadbec0
ba9a7ad
4d17eb8
b251fe0
a7b74db
ccea112
381f111
27d2393
4d613e7
9b55b2e
3e65857
03cba0e
9d6a47e
1e0b94f
218f085
ce93c66
0894f6e
2279efd
d99c05a
b857097
673ee5d
858ae42
0adc929
9fbc5bb
5667a34
e021618
0c904eb
1ae3ebe
5c657e1
3639cda
14000a4
84d1ee0
93c3e02
b116981
bc1c428
8c96a51
ba2de0e
af20438
403f198
6169636
273a36b
771464b
fff3504
d21d63d
ca46df3
657a4aa
4e58847
3519c0f
7c55e03
371e9ae
856a96c
e5fc785
ed075ec
cb460f7
f4820af
7273280
df7b4ca
c32423f
2dc4838
2c4579b
9e69323
ded6663
9136d67
b17e9d1
aab2cd9
45bfd12
44e0fdc
ab7753f
c60226e
89cabd5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be a bigger task? out of scope of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hashing changes length so pass cannot be validated at model level unless we hash there as well - probably worth discussing. Since the helper is used by multiple namespaces, I decided to leave it untouched.