Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): fix BASE_PATH for Vite dev mode #4342

Merged
merged 4 commits into from
Oct 14, 2022

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Oct 14, 2022

No description provided.

@ivov ivov requested a review from netroy October 14, 2022 07:02
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 14, 2022
@netroy netroy merged commit 24288a5 into master Oct 14, 2022
@netroy netroy deleted the fix-base-path-for-vite-dev-mode branch October 14, 2022 08:05
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Oct 14, 2022
@janober
Copy link
Member

janober commented Oct 14, 2022

Got released with n8n@0.198.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Oct 14, 2022
valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
* 🐛 Fix `BASE_PATH` for Vite dev mode

* don't use the string `/{{BASE_PATH}}/` as it gets replaces in build

* fix the static urls on windows

* ffs node 14

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants