Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): fix BASE_PATH for Vite dev mode #4342

Merged
merged 4 commits into from
Oct 14, 2022
Merged

fix(editor): fix BASE_PATH for Vite dev mode #4342

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b033831
:bug: Fix `BASE_PATH` for Vite dev mode
ivov Oct 14, 2022
634064b
don't use the string `/{{BASE_PATH}}/` as it gets replaces in build
netroy Oct 14, 2022
1155163
fix the static urls on windows
netroy Oct 14, 2022
6016cad
ffs node 14
netroy Oct 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/editor-ui/src/router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ function getTemplatesRedirect(store: Store<IRootState>) {

const router = new Router({
mode: 'history',
// @ts-ignore
base: window.BASE_PATH ?? '/',
base: window.BASE_PATH === '/{{BASE_PATH}}/' ? '/' : window.BASE_PATH,
scrollBehavior(to, from, savedPosition) {
netroy marked this conversation as resolved.
Show resolved Hide resolved
// saved position == null means the page is NOT visited from history (back button)
if (savedPosition === null && to.name === VIEWS.TEMPLATES && to.meta) {
Expand Down
4 changes: 4 additions & 0 deletions packages/editor-ui/src/shims.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ declare module 'markdown-it-emoji';
declare module 'markdown-it-task-lists';

declare global {
interface Window {
BASE_PATH: string;
}

namespace JSX {
// tslint:disable no-empty-interface
interface Element extends VNode {}
Expand Down