Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(TelegramTrigger Node, ShopifyTrigger Node): Standardize node triggers actions #5117

Merged
merged 3 commits into from
Jan 10, 2023
Merged

refactor(TelegramTrigger Node, ShopifyTrigger Node): Standardize node triggers actions #5117

merged 3 commits into from
Jan 10, 2023

Conversation

OlegIvaniv
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@OlegIvaniv OlegIvaniv self-assigned this Jan 10, 2023
@OlegIvaniv OlegIvaniv changed the title feat(Telegram Trigger node, Shopify Trigger node): Standardize Telegram and Shopify triggers actions feat(TelegramTrigger Node, ShopifyTrigger Node): Standardize Telegram and Shopify triggers actions Jan 10, 2023
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request ui Enhancement in /editor-ui or /design-system labels Jan 10, 2023
ivov
ivov approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. PR title should prolly use refactor and omit node names, already mentioned in scope.

packages/editor-ui/src/stores/nodeCreator.ts Show resolved Hide resolved
@OlegIvaniv OlegIvaniv changed the title feat(TelegramTrigger Node, ShopifyTrigger Node): Standardize Telegram and Shopify triggers actions refactor(TelegramTrigger Node, ShopifyTrigger Node): Standardize Telegram and Shopify triggers actions Jan 10, 2023
@OlegIvaniv OlegIvaniv changed the title refactor(TelegramTrigger Node, ShopifyTrigger Node): Standardize Telegram and Shopify triggers actions refactor(TelegramTrigger Node, ShopifyTrigger Node): Standardize node triggers actions Jan 10, 2023
@OlegIvaniv OlegIvaniv merged commit 8851778 into master Jan 10, 2023
@OlegIvaniv OlegIvaniv deleted the ado-169-standardize-telegram-shopify-triggers branch January 10, 2023 10:20
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Jan 10, 2023
MiloradFilipovic added a commit that referenced this pull request Jan 11, 2023
@MiloradFilipovic
Merge branch 'master' into ado-6-ndv-simplify-credentials
18ed51a 
* master:
  fix(core): Fixes event msg confirmations if no subscribers present (#5118)
  refactor(core): Diverge syntax error handling in expressions (#5124)
  fix(editor): Recover from unsaved finished execution  (#5121)
  feat(editor): Executions page (#4997)
  docs: Update the contribution guidelines for node creation (#5120)
  feat: Expression extension framework (#4372)
  fix(editor): Fixes event bus test (#5119)
  refactor(TelegramTrigger Node, ShopifyTrigger Node): Standardize node triggers actions (#5117)
  feat(editor): Remove prevent-ndv-auto-open feature flag (#5114)
  refactor: On workflow deletion, cascade delete all entities associated with it (#5102)

# Conflicts:
#	packages/editor-ui/src/Interface.ts
@janober
Copy link
Member

janober commented Jan 13, 2023

Got released with n8n@0.211.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivov ivov ivov approved these changes

Assignees

@OlegIvaniv OlegIvaniv

Labels
n8n team Authored by the n8n team node/improvement New feature or request ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OlegIvaniv @janober @ivov