Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(TelegramTrigger Node, ShopifyTrigger Node): Standardize node triggers actions #5117

Merged
merged 3 commits into from
Jan 10, 2023
Merged

refactor(TelegramTrigger Node, ShopifyTrigger Node): Standardize node triggers actions #5117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
412ae28
feat(Telegram Trigger node, Shopify Trigger node): Change display nam…
OlegIvaniv Jan 9, 2023
e0da2cc
Remove trigger on tooltips for Telegram and Shopify trigger nodes
OlegIvaniv Jan 9, 2023
26f398a
Add telegram action override and make sure recommended category actio…
OlegIvaniv Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/editor-ui/src/stores/nodeCreator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,9 +166,11 @@ function recommendedCategory(
i18n.baseText('nodeCreator.actionsCategory.recommended'),
),
actionKey: categoryItem.value as string,
displayName: i18n.baseText('nodeCreator.actionsCategory.onEvent', {
interpolate: { event: startCase(categoryItem.name) },
}),
displayName:
categoryItem.action ??
OlegIvaniv marked this conversation as resolved.
Show resolved Hide resolved
i18n.baseText('nodeCreator.actionsCategory.onEvent', {
interpolate: { event: startCase(categoryItem.name) },
}),
description: categoryItem.description || '',
displayOptions: matchedProperty.displayOptions,
values: {
Expand Down
3 changes: 1 addition & 2 deletions packages/nodes-base/nodes/Shopify/ShopifyTrigger.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export class ShopifyTrigger implements INodeType {
default: 'apiKey',
},
{
displayName: 'Topic',
displayName: 'Trigger On',
name: 'topic',
type: 'options',
default: '',
Expand Down Expand Up @@ -321,7 +321,6 @@ export class ShopifyTrigger implements INodeType {
value: 'themes/update',
},
],
description: 'Event that triggers the webhook',
},
],
};
Expand Down
4 changes: 2 additions & 2 deletions packages/nodes-base/nodes/Telegram/TelegramTrigger.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export class TelegramTrigger implements INodeType {
],
properties: [
{
displayName: 'Updates',
displayName: 'Trigger On',
name: 'updates',
type: 'multiOptions',
options: [
Expand Down Expand Up @@ -81,6 +81,7 @@ export class TelegramTrigger implements INodeType {
{
name: 'Poll',
value: 'poll',
action: 'On Poll Change',
description:
'Trigger on new poll state. Bots receive only updates about stopped polls and polls, which are sent by the bot.',
},
Expand All @@ -99,7 +100,6 @@ export class TelegramTrigger implements INodeType {
],
required: true,
default: [],
description: 'The update types to listen to',
},
{
displayName:
Expand Down