fix(editor): Fix node connection showing incorrect item count during … #9684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
…execution in certain cases
tomi
force-pushed
the
ado-2031-bug-connector-item-counts-are-incorrect-items-total-has
branch
from
51fb249 to
999a62e
Compare
alexgrozav
approved these changes
Jun 10, 2024
|
✅ All Cypress E2E specs passed |
2 flaky tests on run #5392 ↗︎
Details:
|
||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
Review all test suite changes for PR #9684 ↗︎
tomi
deleted the
ado-2031-bug-connector-item-counts-are-incorrect-items-total-has
branch
MiloradFilipovic
added a commit
that referenced
this pull request
Jun 11, 2024
* master: ci: Fix custom docker builds (no-changelog) (#9702) test: Fix e2e for projects missing instance owner (no-changelog) (#9703) ci: Refactor e2e tests to be less flaky (no-changelog) (#9695) feat(editor): Add move resources option to workflows and credentials on (#9654) fix: Introduce `HooksService` (#8962) fix(editor): Improve large data warning in input/output panel (#9671) ci(editor): Enforce type-safety in @n8n/chat builds as well (no-changelog) (#9685) fix(editor): Un-skip workflow save test (no-changelog) (#9698) refactor(core): Remove more dead code from event bus (no-changelog) (#9697) ci: Remove unused WaitTracker mocking (no-changelog) (#9694) feat: Update NPS Value Survey (#9638) refactor(core): Remove event bus channel (no-changelog) (#9663) refactor(core): Remove event bus helpers (no-changelog) (#9690) refactor(core): Merge event bus controllers and remove dead code (no-changelog) (#9688) ci: Fix e2e tests (no-changelog) (#9689) refactor(core): Use `@Licensed()` in event bus controller (no-changelog) (#9687) fix(editor): Node background for executing nodes in dark mode (#9682) fix(editor): Prevent saving already saved workflows (#9670) fix(editor): Fix node connection showing incorrect item count during … (#9684) refactor: Set up Cypress as pnpm workspace (no-changelog) (#6049)
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix node connection showing incorrect item count during execution in certain cases
I tried adding a test case for the
Node.vuecomponent, but there is so much going on in that component that it got very complex to set it up. Hence no test. LMK if you have a good idea how this could be tested (need to either simulate run data passing via webhook or pause the execution after first loop iteration)Before:
Bug.ADO-2031.Kapture.Jun.10.mp4
After:
Kapture.2024-06-10.at.16.09.31.mp4
Related tickets and issues
https://linear.app/n8n/issue/ADO-2031/bug-connector-item-counts-are-incorrect-items-total-has-disappeared
Review / Merge checklist
(no-changelog)otherwise. (conventions)