Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix e2e tests (no-changelog) #9689

Merged
merged 1 commit into from
Jun 10, 2024
Merged

ci: Fix e2e tests (no-changelog) #9689

merged 1 commit into from
Jun 10, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Jun 10, 2024

I accidentally broke e2e in #6049.
This PR updates cypress related paths to be relative, to avoid issues like this in the future.

Review / Merge checklist

  • PR title and summary are descriptive

Copy link

cypress bot commented Jun 10, 2024

1 failed and 1 flaky tests on run #5398 ↗︎

1 80 0 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: 2f44c3756f
Status: Failed Duration: 04:59 💡
Started: Jun 10, 2024 3:01 PM Ended: Jun 10, 2024 3:06 PM
Failed  29-templates.cy.ts • 1 failed test

View Output Video

Test Artifacts
Workflow templates > Redirects to website when visiting templates page directly Test Replay Screenshots Video
Failed  4-node-creator.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  7-workflow-actions.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  16-webhook-node.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  12-canvas-actions.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 49 specs in Cypress Cloud.

Flakiness  e2e/5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > Stop listening for trigger event from NDV Screenshots Video

Review all test suite changes for PR #9689 ↗︎

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jun 10, 2024
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@netroy netroy merged commit 2521daa into master Jun 10, 2024
46 of 50 checks passed
@netroy netroy deleted the fix-e2e branch June 10, 2024 15:18
MiloradFilipovic added a commit that referenced this pull request Jun 11, 2024
* master:
  ci: Fix custom docker builds (no-changelog) (#9702)
  test: Fix e2e for projects missing instance owner (no-changelog) (#9703)
  ci: Refactor e2e tests to be less flaky (no-changelog) (#9695)
  feat(editor): Add move resources option to workflows and credentials on (#9654)
  fix: Introduce `HooksService` (#8962)
  fix(editor): Improve large data warning in input/output panel (#9671)
  ci(editor): Enforce type-safety in @n8n/chat builds as well (no-changelog) (#9685)
  fix(editor): Un-skip workflow save test (no-changelog) (#9698)
  refactor(core): Remove more dead code from event bus (no-changelog) (#9697)
  ci: Remove unused WaitTracker mocking (no-changelog) (#9694)
  feat: Update NPS Value Survey (#9638)
  refactor(core): Remove event bus channel (no-changelog) (#9663)
  refactor(core): Remove event bus helpers (no-changelog) (#9690)
  refactor(core): Merge event bus controllers and remove dead code (no-changelog) (#9688)
  ci: Fix e2e tests (no-changelog) (#9689)
  refactor(core): Use `@Licensed()` in event bus controller (no-changelog) (#9687)
  fix(editor): Node background for executing nodes in dark mode (#9682)
  fix(editor): Prevent saving already saved workflows (#9670)
  fix(editor): Fix node connection showing incorrect item count during … (#9684)
  refactor: Set up Cypress as pnpm workspace (no-changelog) (#6049)
@janober
Copy link
Member

janober commented Jun 12, 2024

Got released with n8n@1.46.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants