fix: Get workflow not returning home project and shared projects (no-changelog) #9815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
valya
changed the title
despairblue
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Small suggestion for a comment in the test. Logic looks good. Does this fix PAY-1562? If so we should add mention the ticket in the description, right?
|
|
||
| test('should return workflow credentials home project and shared with projects', async () => { | ||
| const savedCredential = await saveCredential(randomCredentialPayload(), { user: member }); | ||
| // Both users have access to the credential (none is owner) |
There was a problem hiding this comment.
Suggested change
| // Both users have access to the credential (none is owner) | |
| // Both users have access to the credential (none is global owner) |
Maybe? Just differentiating from owning the cred, which member does.
2 flaky tests on run #5601 ↗︎
Details:
|
||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
Review all test suite changes for PR #9815 ↗︎
|
✅ All Cypress E2E specs passed |
valya
deleted the
pay-1562-no-way-to-know-who-the-owner-of-a-shared-credential-is
branch
longnz
added a commit
to AcclaroInc/workflow-automation
that referenced
this pull request
Jun 21, 2024
* 'master' of github.com:n8n-io/n8n: (380 commits) feat(Anthropic Chat Model Node): Add support for Claude 3.5 Sonnet (n8n-io#9832) refactor(core): Remove inferral of execution status (no-changelog) (n8n-io#9829) refactor(core): Log denials from subworkflow caller policy (no-changelog) (n8n-io#9827) fix(Zulip Node): Fix a typo preventing some messages from updating (n8n-io#7078) 🚀 Release 1.47.0 (n8n-io#9826) ci: Fix repository url for provenance checks (no-changelog) (n8n-io#9825) docs: Update docs links in the HTTP node (no-changelog) (n8n-io#9188) feat(Pipedrive Node): Add sort field for get all persons (n8n-io#8138) ci: Add opencontainer image spec labels to the release Dockerfile (no-changelog) (n8n-io#9822) fix(core): Upgrade `ws` to address CVE-2024-37890 (n8n-io#9801) ci: Fix ARM custom images (no-changelog) (n8n-io#9821) fix: Get workflow not returning home project and shared projects (no-changelog) (n8n-io#9815) fix(AWS SES Node): Fix issue with email aliases not working for sending from or sending to (n8n-io#9811) fix(Google Sheets Node): Check for column names changes before upsert, append, update (n8n-io#9649) fix(MongoDB Node): Correct typo in MongoDbProperties (no-changelog) (n8n-io#9587) fix(editor): Console error in ActionsMode when searching for action and pressing enter (no-changelog) (n8n-io#9292) fix(Airtable Node): Make multipleRecordLinks editable in fields (n8n-io#9608) refactor(editor): Refactor code editors to composition API (no-changelog) (n8n-io#9757) refactor: Correct spelling mistakes (no-changelog) (n8n-io#9305) fix(editor): Align all cell contents to the top in RunDataTable (no-changelog) (n8n-io#3889) ...
longnz
added a commit
to AcclaroInc/workflow-automation
that referenced
this pull request
Jun 21, 2024
* n8n-io-master: (380 commits) feat(Anthropic Chat Model Node): Add support for Claude 3.5 Sonnet (n8n-io#9832) refactor(core): Remove inferral of execution status (no-changelog) (n8n-io#9829) refactor(core): Log denials from subworkflow caller policy (no-changelog) (n8n-io#9827) fix(Zulip Node): Fix a typo preventing some messages from updating (n8n-io#7078) 🚀 Release 1.47.0 (n8n-io#9826) ci: Fix repository url for provenance checks (no-changelog) (n8n-io#9825) docs: Update docs links in the HTTP node (no-changelog) (n8n-io#9188) feat(Pipedrive Node): Add sort field for get all persons (n8n-io#8138) ci: Add opencontainer image spec labels to the release Dockerfile (no-changelog) (n8n-io#9822) fix(core): Upgrade `ws` to address CVE-2024-37890 (n8n-io#9801) ci: Fix ARM custom images (no-changelog) (n8n-io#9821) fix: Get workflow not returning home project and shared projects (no-changelog) (n8n-io#9815) fix(AWS SES Node): Fix issue with email aliases not working for sending from or sending to (n8n-io#9811) fix(Google Sheets Node): Check for column names changes before upsert, append, update (n8n-io#9649) fix(MongoDB Node): Correct typo in MongoDbProperties (no-changelog) (n8n-io#9587) fix(editor): Console error in ActionsMode when searching for action and pressing enter (no-changelog) (n8n-io#9292) fix(Airtable Node): Make multipleRecordLinks editable in fields (n8n-io#9608) refactor(editor): Refactor code editors to composition API (no-changelog) (n8n-io#9757) refactor: Correct spelling mistakes (no-changelog) (n8n-io#9305) fix(editor): Align all cell contents to the top in RunDataTable (no-changelog) (n8n-io#3889) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we moved to RBAC, we stopped returning the
ownedByandsharedWithproperties onusedCredentials, and when doing so, we failed to return the newhomeProjectandsharedWithProjectsproperties instead.Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)