Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Log denials from subworkflow caller policy (no-changelog) #9827

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jun 21, 2024

For easier debugging in issues like this: https://linear.app/n8n/issue/PAY-1694

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jun 21, 2024
Copy link

cypress bot commented Jun 21, 2024

3 flaky tests on run #5624 ↗︎

0 395 0 0 Flakiness 3

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project: n8n Commit: ad55aa9ee5
Status: Passed Duration: 04:25 💡
Started: Jun 21, 2024 8:41 AM Ended: Jun 21, 2024 8:45 AM
Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
Flakiness  10-undo-redo.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Undo/Redo > should undo/redo adding connected nodes Test Replay Screenshots Video
Flakiness  12-canvas-actions.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Canvas Actions > Node hover actions > should execute node Test Replay Screenshots Video

Review all test suite changes for PR #9827 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit f0ee0a1 into master Jun 21, 2024
27 checks passed
@ivov ivov deleted the subworkflow-caller-policy-logs branch June 21, 2024 08:47
longnz added a commit to AcclaroInc/workflow-automation that referenced this pull request Jun 21, 2024
* 'master' of github.com:n8n-io/n8n: (380 commits)
  feat(Anthropic Chat Model Node): Add support for Claude 3.5 Sonnet (n8n-io#9832)
  refactor(core): Remove inferral of execution status (no-changelog) (n8n-io#9829)
  refactor(core): Log denials from subworkflow caller policy (no-changelog) (n8n-io#9827)
  fix(Zulip Node): Fix a typo preventing some messages from updating (n8n-io#7078)
  🚀 Release 1.47.0 (n8n-io#9826)
  ci: Fix repository url for provenance checks (no-changelog) (n8n-io#9825)
  docs: Update docs links in the HTTP node (no-changelog) (n8n-io#9188)
  feat(Pipedrive Node): Add sort field for get all persons (n8n-io#8138)
  ci: Add opencontainer image spec labels to the release Dockerfile (no-changelog) (n8n-io#9822)
  fix(core): Upgrade `ws` to address CVE-2024-37890 (n8n-io#9801)
  ci: Fix ARM custom images (no-changelog) (n8n-io#9821)
  fix: Get workflow not returning home project and shared projects (no-changelog) (n8n-io#9815)
  fix(AWS SES Node): Fix issue with email aliases not working for sending from or sending to (n8n-io#9811)
  fix(Google Sheets Node): Check for column names changes before upsert, append, update (n8n-io#9649)
  fix(MongoDB Node): Correct typo in MongoDbProperties (no-changelog) (n8n-io#9587)
  fix(editor): Console error in ActionsMode when searching for action and pressing enter (no-changelog) (n8n-io#9292)
  fix(Airtable Node): Make multipleRecordLinks editable in fields (n8n-io#9608)
  refactor(editor): Refactor code editors to composition API (no-changelog) (n8n-io#9757)
  refactor: Correct spelling mistakes (no-changelog) (n8n-io#9305)
  fix(editor): Align all cell contents to the top in RunDataTable (no-changelog) (n8n-io#3889)
  ...
longnz added a commit to AcclaroInc/workflow-automation that referenced this pull request Jun 21, 2024
* n8n-io-master: (380 commits)
  feat(Anthropic Chat Model Node): Add support for Claude 3.5 Sonnet (n8n-io#9832)
  refactor(core): Remove inferral of execution status (no-changelog) (n8n-io#9829)
  refactor(core): Log denials from subworkflow caller policy (no-changelog) (n8n-io#9827)
  fix(Zulip Node): Fix a typo preventing some messages from updating (n8n-io#7078)
  🚀 Release 1.47.0 (n8n-io#9826)
  ci: Fix repository url for provenance checks (no-changelog) (n8n-io#9825)
  docs: Update docs links in the HTTP node (no-changelog) (n8n-io#9188)
  feat(Pipedrive Node): Add sort field for get all persons (n8n-io#8138)
  ci: Add opencontainer image spec labels to the release Dockerfile (no-changelog) (n8n-io#9822)
  fix(core): Upgrade `ws` to address CVE-2024-37890 (n8n-io#9801)
  ci: Fix ARM custom images (no-changelog) (n8n-io#9821)
  fix: Get workflow not returning home project and shared projects (no-changelog) (n8n-io#9815)
  fix(AWS SES Node): Fix issue with email aliases not working for sending from or sending to (n8n-io#9811)
  fix(Google Sheets Node): Check for column names changes before upsert, append, update (n8n-io#9649)
  fix(MongoDB Node): Correct typo in MongoDbProperties (no-changelog) (n8n-io#9587)
  fix(editor): Console error in ActionsMode when searching for action and pressing enter (no-changelog) (n8n-io#9292)
  fix(Airtable Node): Make multipleRecordLinks editable in fields (n8n-io#9608)
  refactor(editor): Refactor code editors to composition API (no-changelog) (n8n-io#9757)
  refactor: Correct spelling mistakes (no-changelog) (n8n-io#9305)
  fix(editor): Align all cell contents to the top in RunDataTable (no-changelog) (n8n-io#3889)
  ...
@janober
Copy link
Member

janober commented Jun 27, 2024

Got released with n8n@1.48.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants