Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to detect if gameobjects/maps should be built #51

Closed
gtker opened this issue Jul 6, 2023 · 2 comments · Fixed by #55
Closed

Add ability to detect if gameobjects/maps should be built #51

gtker opened this issue Jul 6, 2023 · 2 comments · Fixed by #55

Comments

@gtker
Copy link

gtker commented Jul 6, 2023

Currently running the mapbuild_build_bvh and mapbuild_build_map functions don't test if the output files already exist.
It would be nice to have a (C API) way of testing whether it is necessary to build gameobjects/maps.

This could be either an external function in the C API or built into the current functions.

@namreeb
Copy link
Owner

namreeb commented Jul 30, 2023

The way this is intended to work is all BVHs are built as its own step (./MapBuild --bvh). So I don't quite follow what you're asking for here.

@gtker
Copy link
Author

gtker commented Jul 31, 2023

I want, for example, a C function with a declaration of

uint8_t game_objects_and_maps_built(char* directory);

That tells me (via 1 for true and 0 for false) whether the directory passed to the function contains "valid" namigator files, which means I don't have to build BVHs and Maps again, and can just read directly from the directory.

What exactly "valid" means in this context is undecided. Initially it could probably just check whether a BVH directory existed in the path, or if the directory contained some other file known to be from namigator.

I want this functionality in namigator itself and not manually implemented by me so that I'm not relying on implementation details that might suddenly change.

I don't see this as having to work together with #49, since if I can control where the navigation files are stored I can also known whether they require a build/rebuild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants