Replace Boost with Pybind11 + Add checking if BVH/maps built + Add C API docs #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 5, 2023 19:06
Fixes namreeb#31. pybind11 appears to work with both Python 2 and 3. pybind11 appears to name the final shared objects as mapbuild.cpython-310-x86_64-linux-gnu.so instead of just mapbuild.so But Python appears to handle this just fine.
|
Forgot to make |
|
This all looks good to me, thanks! I have no problem with submitting the package to PyPI. Are you willing to create another MR with the appropriate CI change? Or is this something I'll have to setup? |
I have one coming right up but you'll need a PyPI account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31.
Fixes #51.
Fixes #52.
If this PR is too big I can split it up into individual parts, but the commits are completely separate so I didn't think it would matter.
I went for including Pybind11 by source because I don't think there's really anyone who has it installed, and it's going to be a pain on windows.
I would like to get the Python bindings on PyPI for easier install and usage. I'm intending on just setting up the CI so that it can push to PyPI when a commit is tagged with a version or something, would you have anything against this?