Add argument names and docstrings for Python files + Fix nested filesystem folders #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 20, 2023 15:00
By default `pybind11` just calls the arguments `arg0`, `arg1`, etc., which is less than ideal.
This logic was duplicated across the MapBuilder executable, the Python bindngs and the C bindings.
Fixes namreeb#64. `create_directories` does nothing if the directory already exists, so there is no need to check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default
pybind11just calls the argumentsarg0,arg1, etc., which is less than ideal. This should make it significantly nicer to use the Python API with an IDE.This PR also unifies the path handling across the exe, python and C.
create_directoriesdoes nothing if the directory already exists, so there's no need to check.Fixes #64.