Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add argument names and docstrings for Python files + Fix nested filesystem folders #65

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Add argument names and docstrings for Python files + Fix nested filesystem folders #65

merged 3 commits into from
Oct 12, 2023

Commits on Sep 20, 2023

  1. Add argument names and docstrings for Python files 

    By default `pybind11` just calls the arguments `arg0`, `arg1`, etc.,
which is less than ideal.
    Gtker committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    b9bc2ad View commit details
    Browse the repository at this point in the history

  2. Refactor file system creation into separate functions 

    This logic was duplicated across the MapBuilder executable, the Python
bindngs and the C bindings.
    Gtker committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    2ae1c47 View commit details
    Browse the repository at this point in the history

  3. Fix being unable to create directories deeper than 1 

    Fixes namreeb#64.

`create_directories` does nothing if the directory already exists, so
there is no need to check.
    Gtker committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    832b19f View commit details
    Browse the repository at this point in the history