Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS : Uncaught error response during replace #653

Closed
Atroskelis opened this issue Feb 14, 2018 · 0 comments
Closed

IOS : Uncaught error response during replace #653

Atroskelis opened this issue Feb 14, 2018 · 0 comments

Comments

@Atroskelis
Copy link

Atroskelis commented Feb 14, 2018

Caught this when trying to commit replace an altered post-grab get_config 'startup' which adds an unsupported line on line 1

 head config.txt 
  
Using 1316 out of 196600 bytes
!
! Last configuration change at 15:49:05 BUC Wed Feb 14 2018 by root
version 15.1
service timestamps debug datetime msec
service timestamps log datetime msec
service password-encryption
!
hostname NAPALM-TARGET
!

Cisco 1841 Version 12.4(13r)t issues the following when doing

replace flash:candidate_config.txt force revert trigger error

The response is

%The input file is not a valid config file.

Napalm goes forward with the code, even if changes are not applied on the router. I may not be that good at Python, but i assume this code bit does not have this answer in order to raise exception

            if self.auto_rollback_on_error:
                cmd = 'configure replace {} force revert trigger error'.format(cfg_file)
            else:
                cmd = 'configure replace {} force'.format(cfg_file)
            output = self._commit_hostname_handler⌘
            if ('original configuration has been successfully restored' in output) or \
               ('error' in output.lower()) or \
               ('failed' in output.lower()):
                msg = "Candidate config could not be applied\n{}".format(output)
                raise ReplaceConfigException(msg)

Could we add this text to the code?

ktbyers added a commit that referenced this issue Apr 12, 2018
* Remove multiple entries for netmiko (#617)

* Fixes NX-OS string change in show diff rollback-patch output (#619)

* Require to upgrade setuptools

* Modify NX-OS to properly save config to startup-config on commit_config (#624)

* Fixing NX-OS rollback issue (#626)

* Junos fix next-hop self in get_bgp_config() (#620)

* junos fix nhs in get_bgp_config()

* junos add test case for nhs in get_bgp_config()

* junos fix missing policy in existing test case for nhs

* junos fix E712 comparison

* fix typo

* junos remove nhs key in group level in get_bgp_config()

* junos rework nhs in get_bgp_config() by fetching all policies in one go

* junos fix test case for nhs get_bgp_config()

* junos clean code and add comments in nhs get_bgp_config()

* junos nhs remove inactive term in mocked data

* IOS-XR: return the is_alive flag for the SSH channel (#623)

* Fixes for CAM and ARP parsing issues in nxos_ssh.py (#634)

* Fixes #441, Fixes #633 show arp and mac address table processing.

* Minor improvement to get_arp processing on NXOS SSH (#639)

* Minor improvement to get_arp processing on NXOS SSH

* don't hide relevant import errors (#635)

* don't hide relevant import errors

* original name

* py2 compliance

* now back to py3 compatibility....

* Update index.rst (#650)

* improved exceptions - added new base exception (#649)

* improved exceptions - added new base exception

* fixed pep8 issue

* another pep8 issue fixed

* fixes #640 junos ConnectionException (#648)

* FIXES #653 additional error message on failed replace (#654)

* NX-OS ping implementation using more shared common code (#642)

* fix get_mac_table on IOS when there are routed ports

* [646] updating junos.py to support PTX platform (#665)

* Minor doc changes for NX-OS and IOS (#669)

* Unify netmiko argument processing across napalm drivers (#673)

* Start sharing common Netmiko code

* Adding unit tests for new netmiko argument parsing

* Adding NXOS to use netmiko argument processing

* IOS-XR and netmiko args processing

* Make nxos_facts behavior more consistent between NX-API and SSH (#674)

* fix issue #477: the output is now consistent between NXOS and NXOS_SSH driver

* #477 fix crash for some N9K 93180YC-EX, 93180LC-EX, etc

* Updates to NX-OS SSH get_facts

* Adding better test case for NX-API

* Update get_interfaces_ip to deal with unnumbered interfaces (#632)

* Update get_interfaces_ip to deal with unnumbered interfaces

* Extend tests for show_ip_interface

* Fix issue about N9K with vxlan (#676)

* Adding VXLAN support: EVPN and control plane flags on mac address + new interface name

* Fix #672: get_interfaces() crash with nve interfaces or no IP address

* fix missing mgmt0 interface in the get_fact on N9K device

* fix wrong description SVI on N9K device

* fix some pep error and an EOL issue for a test case

* Fix setup.py issue when using pip 10. (#692)

* Add virtualbox provider to the docs (#679)

* Apply correct format to code block

* Add virtualbox provider flag to vagrant

* Lldp neighbors detail bugfix (#675)

* Cosmetic cleanup in line with PEP8, whitespace and indentation fixes

* Address inconsistency in junos xml rpc calls for lldp interface information.

* Add two more cases where the RPC call for lldp neighbors interface detail is different to that documented

* Add StackStorm integrations to README (#683)

* Track BGP state to report is_up (#684)

* NAPALM release 2.3.1 (#696)

* Rolling version to 2.3.1

* Fixing linter issues introduced by new version of pylama
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant