-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for CAM and ARP parsing issues in nxos_ssh.py #634
Conversation
Updated mock data in test suite to account for 2 new cases
napalm/nxos_ssh/nxos_ssh.py
Outdated
@@ -1056,6 +1056,8 @@ def get_arp_table(self): | |||
for line in arp_entries.splitlines(): | |||
if len(line.split()) == 4: | |||
address, age, mac, interface = line.split() | |||
elif len(line.split()) == 5: | |||
address, age, mac, interface, flag = line.split() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to test if the flag is one of the four options?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see the point in doing that personally unless we plan to use that value for something. Currently it is just assigned and later garbage collected. But, if there is a use case for collecting it and using it in the code later I could do that and add appropriate testing. What did you have in mind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or is your concern more that down the road some other value could land in there as Cisco changes the output some day?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, something like:
address, age, mac, interface = line.split()[:4]
Might be more resilient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough! I’ll change it here in a bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
* Remove multiple entries for netmiko (#617) * Fixes NX-OS string change in show diff rollback-patch output (#619) * Require to upgrade setuptools * Modify NX-OS to properly save config to startup-config on commit_config (#624) * Fixing NX-OS rollback issue (#626) * Junos fix next-hop self in get_bgp_config() (#620) * junos fix nhs in get_bgp_config() * junos add test case for nhs in get_bgp_config() * junos fix missing policy in existing test case for nhs * junos fix E712 comparison * fix typo * junos remove nhs key in group level in get_bgp_config() * junos rework nhs in get_bgp_config() by fetching all policies in one go * junos fix test case for nhs get_bgp_config() * junos clean code and add comments in nhs get_bgp_config() * junos nhs remove inactive term in mocked data * IOS-XR: return the is_alive flag for the SSH channel (#623) * Fixes for CAM and ARP parsing issues in nxos_ssh.py (#634) * Fixes #441, Fixes #633 show arp and mac address table processing. * Minor improvement to get_arp processing on NXOS SSH (#639) * Minor improvement to get_arp processing on NXOS SSH * don't hide relevant import errors (#635) * don't hide relevant import errors * original name * py2 compliance * now back to py3 compatibility.... * Update index.rst (#650) * improved exceptions - added new base exception (#649) * improved exceptions - added new base exception * fixed pep8 issue * another pep8 issue fixed * fixes #640 junos ConnectionException (#648) * FIXES #653 additional error message on failed replace (#654) * NX-OS ping implementation using more shared common code (#642) * fix get_mac_table on IOS when there are routed ports * [646] updating junos.py to support PTX platform (#665) * Minor doc changes for NX-OS and IOS (#669) * Unify netmiko argument processing across napalm drivers (#673) * Start sharing common Netmiko code * Adding unit tests for new netmiko argument parsing * Adding NXOS to use netmiko argument processing * IOS-XR and netmiko args processing * Make nxos_facts behavior more consistent between NX-API and SSH (#674) * fix issue #477: the output is now consistent between NXOS and NXOS_SSH driver * #477 fix crash for some N9K 93180YC-EX, 93180LC-EX, etc * Updates to NX-OS SSH get_facts * Adding better test case for NX-API * Update get_interfaces_ip to deal with unnumbered interfaces (#632) * Update get_interfaces_ip to deal with unnumbered interfaces * Extend tests for show_ip_interface * Fix issue about N9K with vxlan (#676) * Adding VXLAN support: EVPN and control plane flags on mac address + new interface name * Fix #672: get_interfaces() crash with nve interfaces or no IP address * fix missing mgmt0 interface in the get_fact on N9K device * fix wrong description SVI on N9K device * fix some pep error and an EOL issue for a test case * Fix setup.py issue when using pip 10. (#692) * Add virtualbox provider to the docs (#679) * Apply correct format to code block * Add virtualbox provider flag to vagrant * Lldp neighbors detail bugfix (#675) * Cosmetic cleanup in line with PEP8, whitespace and indentation fixes * Address inconsistency in junos xml rpc calls for lldp interface information. * Add two more cases where the RPC call for lldp neighbors interface detail is different to that documented * Add StackStorm integrations to README (#683) * Track BGP state to report is_up (#684) * NAPALM release 2.3.1 (#696) * Rolling version to 2.3.1 * Fixing linter issues introduced by new version of pylama
I happened to hit both of these today and saw an old issue open on one (#441) and created a new issue for discussion on the other (#633). Attached are simple fixes for each that I patched into my local instance...