Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install FFMPEG with brew on Mac CI runners #214

Closed
wants to merge 9 commits into from

Conversation

GenevieveBuckley
Copy link
Contributor

Closes #213

This is a temporary fix for issue imageio/imageio-ffmpeg#71, which has been causing our CI to fail.

@GenevieveBuckley
Copy link
Contributor Author

The ruff CI check failed earlier because I updated ruff's target version of python from 3.8 to 3.12. To keep things simple, I've reverted that change here for now, and made a separate PR to update ruff #218.

@psobolewskiPhD
Copy link
Member

Thanks for taking a look at this!

The pyside changes (at a minimum) from here:
23cdaa8 (#214)
will need to be reverted:
The latest pyside2 on pypi is 5.15.2.1
https://pypi.org/project/PySide2/
Which doesn't (officially) support even python 3.10, let alone 3.11 and 3.12:
https://wiki.qt.io/Qt_for_Python
image

Also, to echo Grzegorz's question, why not use the homebrew installed on the macOS runners?
The action you are using
https://github.com/AnimMouse/setup-ffmpeg
Does not support arm64 as far as I can tell:
https://evermeet.cx/ffmpeg/apple-silicon-arm

The other option/alternative PR is to switch to macOS-13 instead of latest (the x86 runners).
And then maybe we consider a different imageio plugin with better wheel support:
#217

@GenevieveBuckley GenevieveBuckley marked this pull request as draft June 4, 2024 04:06
@GenevieveBuckley
Copy link
Contributor Author

why not use the homebrew installed on the macOS runners?

I saw several brew actions available on the github marketplace, and assumed that meant the default runners did not come with it already installed.

@GenevieveBuckley
Copy link
Contributor Author

I'm going to close this - even though I've removed the marketplace github action (and this is change can be seen in the workflow file), the action is still being run on the CI jobs. It's probably easiest to delete this, instead of figuring out if there is a cache somewhere.

@GenevieveBuckley
Copy link
Contributor Author

Superseded by #222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix failing CI tests
3 participants