Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing CI tests (ffmpeg on apple silicon, PySide2 problems) #222

Merged
merged 6 commits into from
Jun 4, 2024

Conversation

GenevieveBuckley
Copy link
Contributor

@GenevieveBuckley GenevieveBuckley commented Jun 4, 2024

In this PR:

  1. brew install ffmpeg for Apple Silicon Mac arm64 runners on github actions, since imageio-ffmpeg does not provide ffmpeg binaries for Apple Silicon ffmpeg not included in wheel for MacOS M1 imageio/imageio-ffmpeg#71
  2. Restrict PySide tests to Mac Intel (not Apple Silicon), and for all operating systems python>=3.10. PySide is not available for these configurations.
  3. Drop python 3.8, and add python 3.12 to the CI test matrix

@GenevieveBuckley GenevieveBuckley changed the title Install ffmpeg separately for Apple Silicon mac Fix failing CI tests (ffmpeg on apple silicon, PySide2 problems) Jun 4, 2024
@jni
Copy link
Member

jni commented Jun 4, 2024

Nice, thanks @GenevieveBuckley!

@jni jni merged commit cc94faf into napari:main Jun 4, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants