Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PSP stubs from MM #94

Closed
3 tasks done
jphickey opened this issue Aug 7, 2024 · 0 comments · Fixed by #95
Closed
3 tasks done

Remove PSP stubs from MM #94

jphickey opened this issue Aug 7, 2024 · 0 comments · Fixed by #95
Assignees
@jphickey

Comments

@jphickey
Copy link
Contributor

jphickey commented Aug 7, 2024

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the README file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
The MM coverage test contains stubs for some PSP functions. These stubs will be added to the official PSP in nasa/PSP#435,

Describe the solution you'd like
MM should use the stubs provided by the PSP - the local copy will conflict with them, and should be removed.

Additional context
May need to put this in an OMIT_DEPRECATED block to avoid breaking builds.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Aug 7, 2024
jphickey added a commit to jphickey/MM that referenced this issue Aug 7, 2024
@jphickey
Fix nasa#94, deprecate PSP stubs in MM coverage tets
f4de6e7 
Only include PSP stubs if the OMIT_DEPRECATED flag is unset.
The PSP now provides the full set of stubs.
@jphickey jphickey mentioned this issue Aug 7, 2024
Merged
2 tasks
jphickey added a commit to jphickey/MM that referenced this issue Aug 15, 2024
@jphickey
Fix nasa#94, deprecate PSP stubs in MM coverage tets
2d6482a 
The PSP now provides the full set of stubs.

IMPORTANT: This needs to be merged in conjunction with nasa/PSP#436 to
obtain the complete set of stubs.  Otherwise the link will fail.
dzbaker added a commit that referenced this issue Sep 23, 2024
@dzbaker
Merge pull request #95 from jphickey/fix-94-deprecate-psp-stubs
75825d6 
Fix #94, deprecate PSP stubs in MM coverage tets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #94, deprecate PSP stubs in MM coverage tets jphickey/MM
1 participant
@jphickey