Fix #435, add coverage tests for PSP modules #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
added
the
CCB:Ready
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| static uint32 CFE_PSP_ConfigPspModuleListLength = 0; | ||
| static uint32 CFE_PSP_StandardPspModuleListLength = 0; | ||
| CFE_PSP_ModuleListGlobal_t CFE_PSP_MODULE_LIST_GLOBAL; |
Check notice
Code scanning / CodeQL
Global could be static Note
|
|
||
| /*************************************************** | ||
| * | ||
| * Helper function to initialize a list of modules (not externally called) | ||
| * Returns the number of modules initialized | ||
| */ | ||
| uint32_t CFE_PSP_ModuleInitList(uint32 BaseId, CFE_StaticModuleLoadEntry_t *ListPtr) | ||
| void CFE_PSP_ModuleInitList(CFE_PSP_ModuleListWrapper_t *WrapPtr, uint32 BaseId, CFE_StaticModuleLoadEntry_t *ListPtr) |
Check notice
Code scanning / CodeQL
Long function without assertion Note
| * See prototype for full description | ||
| */ | ||
| int32 CFE_PSP_Module_FindByName(const char *ModuleName, uint32 *PspModuleId) | ||
| uint32 CFE_PSP_Module_SearchNameInList(const CFE_PSP_ModuleListWrapper_t *WrapPtr, const char *ModuleName) |
Check notice
Code scanning / CodeQL
Long function without assertion Note
| * | ||
| * See prototype for full description | ||
| */ | ||
| int32 CFE_PSP_Module_FindByName(const char *ModuleName, uint32 *PspModuleId) |
Check notice
Code scanning / CodeQL
Long function without assertion Note
jphickey
force-pushed
the
fix-435-pspmod-covtests
branch
2 times, most recently
from
fc41d65
to
43df4a1
Compare
chillfig
force-pushed
the
fix-435-pspmod-covtests
branch
from
f09f24e
to
6c99a9d
Compare
Yes, it does! Thanks for keeping an eye on the old issues. There are some doc fixes I need to merge in but after that we should be able to close both of those old issues as well. I will link it. |
jphickey
force-pushed
the
fix-435-pspmod-covtests
branch
from
8fe4379
to
c7f6359
Compare
jphickey
added a commit
to jphickey/MD
that referenced
this pull request
Aug 15, 2024
The PSP now provides the complete set of stubs. IMPORTANT: This needs to be used in conjunction with nasa/PSP#436 to get the complete set of stubs, otherwise linking will fail.
jphickey
added a commit
to jphickey/MM
that referenced
this pull request
Aug 15, 2024
The PSP now provides the full set of stubs. IMPORTANT: This needs to be merged in conjunction with nasa/PSP#436 to obtain the complete set of stubs. Otherwise the link will fail.
This was referenced Aug 15, 2024
dzbaker
added
CCB: Provisionally-Approved
and removed
CCB:Ready
|
CCB 15 August 2024: Approved pending removal of commented code. |
dzbaker
added a commit
that referenced
this pull request
Aug 16, 2024
Fix #435, add coverage tests for PSP modules
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Aug 16, 2024
*Combines:* cFE equuleus-rc1+dev187 osal equuleus-rc1+dev85 PSP equuleus-rc1+dev48 **Includes:** *cFE* - nasa/cFE#2591 *osal* - nasa/osal#1419 *PSP* - nasa/PSP#436 Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Jose Martinez Pedraza <pepepr08@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
This was referenced Aug 16, 2024
Adds a coverage test implementation for all existing PSP modules. This should get 100% coverage on all lines and branches.
jphickey
force-pushed
the
fix-435-pspmod-covtests
branch
from
c7f6359
to
fb6c855
Compare
The handler executes after the stub count increments, thus this needs to check for 1 to indicate the first call, not 0.
|
@dzbaker -- The workflow issue is fixed by the commit I just added. Due to the difference in where this code now executes in the overall flow, the counter is now 1 during the first call, not 0 (handlers execute post-increment). |
dzbaker
added
CCB:Approved
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Sep 16, 2024
*Combines:* cFE equuleus-rc1+dev199 PSP equuleus-rc1+dev49 **Includes:** *cFS* - #791 - #796 *cFE* - nasa/cFE#2599 *PSP* - nasa/PSP#439 - nasa/PSP#436 Co-authored by: Andrew Liounis <aliounis@users.noreply.github.com> Co-authored by: Rich Landau <RichLandau@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Sep 19, 2024
*Combines:* cFE equuleus-rc1+dev199 PSP equuleus-rc1+dev49 **Includes:** *cFS* - #791 - #796 *cFE* - nasa/cFE#2599 *PSP* - nasa/PSP#439 - nasa/PSP#436 Co-authored by: Andrew Liounis <aliounis@users.noreply.github.com> Co-authored by: Rich Landau <RichLandau@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
jphickey
added a commit
to nasa/MD
that referenced
this pull request
Sep 23, 2024
The PSP now provides the complete set of stubs. IMPORTANT: This needs to be used in conjunction with nasa/PSP#436 to get the complete set of stubs, otherwise linking will fail.
jphickey
added a commit
to jphickey/MM
that referenced
this pull request
Sep 23, 2024
The PSP now provides the full set of stubs. IMPORTANT: This needs to be merged in conjunction with nasa/PSP#436 to obtain the complete set of stubs. Otherwise the link will fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Adds a coverage test implementation for all existing PSP modules. This should get 100% coverage on all lines and branches.
Fixes #435
Testing performed
Build and run all tests
Expected behavior changes
Complete coverage tests for PSP modules
System(s) tested on
Debian
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.